extensions: Refactor ExtensionInstallUI class.

chrome/browser/extensions/extension_install_ui.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_install_ui.h"
 
 #include <map>
 
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/string_number_conversions.h"
 #include "base/string_util.h"
 #include "base/stringprintf.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/browser_list.h"
 #include "chrome/browser/browser_window.h"
-#include "chrome/browser/extensions/extension_install_dialog.h"
 #include "chrome/browser/extensions/extension_install_dialog2.h"
 #include "chrome/browser/extensions/theme_installed_infobar_delegate.h"
 #include "chrome/browser/platform_util.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/tabs/tab_strip_model.h"
 #include "chrome/browser/themes/theme_service.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_dialogs.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/extensions/extension_icon_set.h"
 #include "chrome/common/extensions/extension_resource.h"
 #include "chrome/common/extensions/url_pattern.h"
 #include "chrome/common/url_constants.h"
 #include "content/browser/tab_contents/tab_contents.h"
 #include "content/common/notification_service.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"
 #include "grit/theme_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 
 #if defined(TOOLKIT_GTK)
 #include "chrome/browser/extensions/gtk_theme_installed_infobar_delegate.h"
 #include "chrome/browser/ui/gtk/gtk_theme_provider.h"
 #endif
 
 // static
 const int ExtensionInstallUI::kTitleIds[NUM_PROMPT_TYPES] = {

[Aaron Boodman, 2011/03/23 21:06:54]

You should remove all the things that got moved to ExtensionGenericPrompt from
this class in this CL.

[tfarina, 2011/03/23 21:12:06]

I can't because extension_install_prompt2_gtk.cc and
extension_install_prompt2.cc are using it. 

   IDS_EXTENSION_INSTALL_PROMPT_TITLE,
   IDS_EXTENSION_UNINSTALL_PROMPT_TITLE,
   IDS_EXTENSION_RE_ENABLE_PROMPT_TITLE
 };
 // static
 const int ExtensionInstallUI::kHeadingIds[NUM_PROMPT_TYPES] = {
   IDS_EXTENSION_INSTALL_PROMPT_HEADING,
   IDS_EXTENSION_UNINSTALL_PROMPT_HEADING,
   IDS_EXTENSION_RE_ENABLE_PROMPT_HEADING
 };
@@ skipping 167 matching lines @@
       NotificationService* service = NotificationService::current();
       service->Notify(NotificationType::EXTENSION_WILL_SHOW_CONFIRM_DIALOG,
           Source<ExtensionInstallUI>(this),
           NotificationService::NoDetails());
 
       std::vector<string16> warnings = extension_->GetPermissionMessages();
       ShowExtensionInstallDialog2(
           profile_, delegate_, extension_, &icon_, warnings, prompt_type_);
       break;
     }
-    case UNINSTALL_PROMPT: {
-      ShowExtensionInstallDialog(
-          profile_, delegate_, extension_, &icon_, UNINSTALL_PROMPT);
-      break;
-    }
     default:
       NOTREACHED() << "Unknown message";
       break;
   }
 }
 
 void ExtensionInstallUI::ShowThemeInfoBar(const std::string& previous_theme_id,
                                           bool previous_use_system_theme,
                                           const Extension* new_theme,
                                           Profile* profile) {
@@ skipping 55 matching lines @@
     const std::string& previous_theme_id,
     bool previous_use_system_theme) {
 #if defined(TOOLKIT_GTK)
   return new GtkThemeInstalledInfoBarDelegate(tab_contents, new_theme,
       previous_theme_id, previous_use_system_theme);
 #else
   return new ThemeInstalledInfoBarDelegate(tab_contents, new_theme,
                                            previous_theme_id);
 #endif
 }