Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 6721013: extensions: Refactor ExtensionInstallUI class. (Closed)

Created:
9 years, 9 months ago by tfarina
Modified:
9 years, 7 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews, Erik does not do reviews, pam+watch_chromium.org
Visibility:
Public.

Description

extensions: Refactor ExtensionInstallUI class. - Remove extension_install_dialog.h. - Add ExtensionUninstallDialog class to handle just the uninstall dialog. BUG=66730 TEST=None R=aa@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79479

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : add ExtensionGenericDialog class #

Patch Set 6 : add Confirm methods to the class #

Patch Set 7 : add message-loop #

Patch Set 8 : start the implementation of the Confirm functions #

Patch Set 9 : add ShowConfirmation function #

Patch Set 10 : remove virtual keyword #

Total comments: 3

Patch Set 11 : add Delegate class #

Patch Set 12 : call ShowConfirmation #

Patch Set 13 : some initialization and implementation #

Patch Set 14 : tweak comments #

Patch Set 15 : start the implementation of OnImageLoaded #

Patch Set 16 : add SetIcon and call it #

Total comments: 1

Patch Set 17 : add static Show function #

Patch Set 18 : implement ExtensionGenericDialog::Show on gtk #

Patch Set 19 : implement ExtensionGenericDialog::Show on views #

Patch Set 20 : implement ExtensionGenericDialog::Show on cocoa #

Patch Set 21 : use ExtensionGenericDialog on more places #

Patch Set 22 : remove UNINSTALL_PROMPT case, as we won't reach it anymore #

Patch Set 23 : rm includes to extension_install_dialog.h #

Patch Set 24 : remove from gypi #

Patch Set 25 : remove the file #

Total comments: 6

Patch Set 26 : remove the includes and move Show to private #

Patch Set 27 : add ShowDialog function #

Patch Set 28 : remove arrays from ExtensionInstallUI #

Patch Set 29 : remove enum parameter #

Patch Set 30 : update copyright year #

Patch Set 31 : remove PromptType enum and cleanup the rest #

Patch Set 32 : more copyright year #

Patch Set 33 : complete rework #

Patch Set 34 : some random fixes #

Patch Set 35 : sort gypi #

Total comments: 4

Patch Set 36 : remove is_uninstall_dialog_ #

Patch Set 37 : rename to ExtensionUninstallDialog #

Patch Set 38 : indentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+378 lines, -262 lines) Patch
M chrome/browser/extensions/extension_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_context_menu_model.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 5 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/extensions/extension_context_menu_model.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/extensions/extension_install_dialog.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 1 chunk +0 lines, -22 lines 0 comments Download
M chrome/browser/extensions/extension_install_ui.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 6 chunks +19 lines, -23 lines 0 comments Download
M chrome/browser/extensions/extension_install_ui.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 4 chunks +0 lines, -19 lines 0 comments Download
A chrome/browser/extensions/extension_uninstall_dialog.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 1 chunk +76 lines, -0 lines 0 comments Download
A chrome/browser/extensions/extension_uninstall_dialog.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 1 chunk +68 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extensions_ui.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 5 chunks +13 lines, -17 lines 0 comments Download
M chrome/browser/extensions/extensions_ui.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 3 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 3 chunks +8 lines, -9 lines 0 comments Download
A + chrome/browser/ui/cocoa/extensions/extension_uninstall_dialog_cocoa.mm View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 3 chunks +13 lines, -13 lines 0 comments Download
A + chrome/browser/ui/gtk/extensions/extension_uninstall_dialog_gtk.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 4 chunks +22 lines, -27 lines 0 comments Download
A + chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 7 chunks +38 lines, -36 lines 0 comments Download
M chrome/browser/ui/webui/app_launcher_handler.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 4 chunks +20 lines, -13 lines 0 comments Download
M chrome/browser/ui/webui/app_launcher_handler.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 4 chunks +45 lines, -28 lines 0 comments Download
M chrome/browser/ui/webui/options/extension_settings_handler.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 6 chunks +17 lines, -18 lines 0 comments Download
M chrome/browser/ui/webui/options/extension_settings_handler.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 3 chunks +9 lines, -7 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 7 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Aaron Boodman
http://codereview.chromium.org/6721013/diff/2019/chrome/browser/extensions/extension_generic_dialog.h File chrome/browser/extensions/extension_generic_dialog.h (right): http://codereview.chromium.org/6721013/diff/2019/chrome/browser/extensions/extension_generic_dialog.h#newcode20 chrome/browser/extensions/extension_generic_dialog.h:20: DIALOG_INSTALL = 0, This one is unneeded in the ...
9 years, 9 months ago (2011-03-23 00:30:19 UTC) #1
Aaron Boodman
Yes, this is the basic gist. http://codereview.chromium.org/6721013/diff/2029/chrome/browser/extensions/extension_install_dialog.h File chrome/browser/extensions/extension_install_dialog.h (right): http://codereview.chromium.org/6721013/diff/2029/chrome/browser/extensions/extension_install_dialog.h#newcode16 chrome/browser/extensions/extension_install_dialog.h:16: void ShowGenericExtensionDialog(Profile* profile, ...
9 years, 9 months ago (2011-03-23 01:04:28 UTC) #2
Aaron Boodman
Nice. Getting there... http://codereview.chromium.org/6721013/diff/1035/chrome/browser/extensions/extension_generic_dialog.h File chrome/browser/extensions/extension_generic_dialog.h (right): http://codereview.chromium.org/6721013/diff/1035/chrome/browser/extensions/extension_generic_dialog.h#newcode49 chrome/browser/extensions/extension_generic_dialog.h:49: static void Show(Profile* profile, I think ...
9 years, 9 months ago (2011-03-23 21:06:54 UTC) #3
tfarina
http://codereview.chromium.org/6721013/diff/1035/chrome/browser/extensions/extension_install_ui.cc File chrome/browser/extensions/extension_install_ui.cc (right): http://codereview.chromium.org/6721013/diff/1035/chrome/browser/extensions/extension_install_ui.cc#newcode44 chrome/browser/extensions/extension_install_ui.cc:44: const int ExtensionInstallUI::kTitleIds[NUM_PROMPT_TYPES] = { On 2011/03/23 21:06:54, Aaron ...
9 years, 9 months ago (2011-03-23 21:12:06 UTC) #4
Aaron Boodman
On 2011/03/23 21:12:06, tfarina wrote: > http://codereview.chromium.org/6721013/diff/1035/chrome/browser/extensions/extension_install_ui.cc > File chrome/browser/extensions/extension_install_ui.cc (right): > > http://codereview.chromium.org/6721013/diff/1035/chrome/browser/extensions/extension_install_ui.cc#newcode44 > ...
9 years, 9 months ago (2011-03-23 22:08:39 UTC) #5
tfarina
Aaron, I think this is ready for another round of review.
9 years, 9 months ago (2011-03-24 17:12:12 UTC) #6
Aaron Boodman
http://codereview.chromium.org/6721013/diff/10004/chrome/browser/extensions/extension_generic_dialog.h File chrome/browser/extensions/extension_generic_dialog.h (right): http://codereview.chromium.org/6721013/diff/10004/chrome/browser/extensions/extension_generic_dialog.h#newcode43 chrome/browser/extensions/extension_generic_dialog.h:43: static void Show(Profile* profile, Currently this class is called ...
9 years, 9 months ago (2011-03-24 19:22:03 UTC) #7
tfarina
http://codereview.chromium.org/6721013/diff/10004/chrome/browser/extensions/extension_generic_dialog.h File chrome/browser/extensions/extension_generic_dialog.h (right): http://codereview.chromium.org/6721013/diff/10004/chrome/browser/extensions/extension_generic_dialog.h#newcode43 chrome/browser/extensions/extension_generic_dialog.h:43: static void Show(Profile* profile, On 2011/03/24 19:22:03, Aaron Boodman ...
9 years, 9 months ago (2011-03-24 21:39:47 UTC) #8
Aaron Boodman
9 years, 9 months ago (2011-03-25 17:50:52 UTC) #9
lgtm

Powered by Google App Engine
This is Rietveld 408576698