Issue 6721003: 64-bit support for Mac OS X in base (NSPR)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6721003: 64-bit support for Mac OS X in base (NSPR) (Closed)

Created:
9 years, 9 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
wtc

CC:
chromium-reviews, pam+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

64-bit support for Mac OS X in base (NSPR). This integrates file revisions 3.11, 3.12, 3.13, and 3.14 from the upstream source, encompassing changes made in upstream bugs 404272, 417044, and 370766. http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/nsprpub/pr/include/md/_darwin.cfg&rev=HEAD&mark=3.14 BUG=44127, 18323 TEST=64-bit base should all (mostly) build Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79070

Total comments: 1

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -1 line)			Patch
	M	base/third_party/nspr/prcpucfg_mac.h	View	1	3 chunks	+53 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

wtc

LGTM. I applied your patch to the Chromium source tree and diffed against NSPR upstream's ...

9 years, 9 months ago (2011-03-22 23:34:07 UTC) #2

Mark Mentovai

9 years, 9 months ago (2011-03-22 23:41:04 UTC) #3

Thanks, I updated this to match the upstream file exactly.