Issue 6720014: Isolates: Cleanup usage of FACTORY in code stubs and bootstrapper.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6720014: Isolates: Cleanup usage of FACTORY in code stubs and bootstrapper. (Closed)

Created:
9 years, 8 months ago by Karl Klose

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Isolates: Cleanup usage of FACTORY in code stubs and bootstrapper.

Patch Set 1 #

Patch Set 2 : Cache isolate in Genesis. #

Patch Set 3 : Minor edits. #

Total comments: 4

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+189 lines, -181 lines)			Patch
M	src/api.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/arm/code-stubs-arm.cc	View		5 chunks	+7 lines, -5 lines	0 comments	Download
M	src/bootstrapper.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/bootstrapper.cc	View	1 2	50 chunks	+159 lines, -161 lines	4 comments	Download
M	src/debug.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View		1 chunk	+6 lines, -4 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	1	6 chunks	+7 lines, -5 lines	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View	1	7 chunks	+7 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

9 years, 8 months ago (2011-04-06 07:34:15 UTC) #2

LGTM

http://codereview.chromium.org/6720014/diff/4001/src/bootstrapper.cc
File src/bootstrapper.cc (right):

http://codereview.chromium.org/6720014/diff/4001/src/bootstrapper.cc#newcode157
src/bootstrapper.cc:157: private:
Could you leave a blank line before the private section?

http://codereview.chromium.org/6720014/diff/4001/src/bootstrapper.cc#newcode703
src/bootstrapper.cc:703: JSGlobalObject::kSize, code, true);
Indentation is off.

http://codereview.chromium.org/6720014/diff/4001/src/bootstrapper.cc#newcode1313
src/bootstrapper.cc:1313: factory()->NewFunction(factory()->empty_symbol(),
factory()->undefined_value());
Line too long.

http://codereview.chromium.org/6720014/diff/4001/src/bootstrapper.cc#newcode1447
src/bootstrapper.cc:1447: // that keeps its field isolate()d from JavaScript
code. It may store
Whoops. :)

Expand Messages | Collapse Messages