Remove the fallback from SOCKSv4 to SOCKSv4a.

Remove the fallback from SOCKSv4 to SOCKSv4a.

BUG=56836
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79658

[wtc, 2011-03-28 22:01:18]

LGTM.  Just some nits.

http://codereview.chromium.org/6719035/diff/1007/net/socket/socks_client_sock...
File net/socket/socks_client_socket.cc (right):

http://codereview.chromium.org/6719035/diff/1007/net/socket/socks_client_sock...
net/socket/socks_client_socket.cc:263: // SOCKS4 only supports IPv4 addresses,
so only try getting the IPv6
Typo: IPv6 => IPv4

http://codereview.chromium.org/6719035/diff/1007/net/socket/socks_client_sock...
net/socket/socks_client_socket.cc:274: // addresses being sent to the SOCKS4
server when it doesn't support 4A.)
Nit: should tbe period '.' be outside the closing parenthesis?

http://codereview.chromium.org/6719035/diff/1007/net/socket/socks_client_sock...
net/socket/socks_client_socket.cc:300: memcpy(&request.ip,
&(ipv4_host->sin_addr), sizeof(ipv4_host->sin_addr));
Nit: remove the parentheses in the second argument.

An experienced system programmer should have no problem
understanding what &ipv4_host->sin_addr means.

http://codereview.chromium.org/6719035/diff/1007/net/socket/socks_client_sock...
File net/socket/socks_client_socket_unittest.cc (right):

http://codereview.chromium.org/6719035/diff/1007/net/socket/socks_client_sock...
net/socket/socks_client_socket_unittest.cc:333: // falling-back to SOCKS4a.
Nit: don't hyphenate "falling-back".

[eroman, 2011-03-29 01:03:49]

http://codereview.chromium.org/6719035/diff/1007/net/socket/socks_client_sock...
File net/socket/socks_client_socket.cc (right):

http://codereview.chromium.org/6719035/diff/1007/net/socket/socks_client_sock...
net/socket/socks_client_socket.cc:263: // SOCKS4 only supports IPv4 addresses,
so only try getting the IPv6
On 2011/03/28 22:01:20, wtc wrote:
> Typo: IPv6 => IPv4

Done.

http://codereview.chromium.org/6719035/diff/1007/net/socket/socks_client_sock...
net/socket/socks_client_socket.cc:274: // addresses being sent to the SOCKS4
server when it doesn't support 4A.)
On 2011/03/28 22:01:20, wtc wrote:
> Nit: should tbe period '.' be outside the closing parenthesis?

I believe it is grammatically correct to be inside the parens.

http://codereview.chromium.org/6719035/diff/1007/net/socket/socks_client_sock...
net/socket/socks_client_socket.cc:300: memcpy(&request.ip,
&(ipv4_host->sin_addr), sizeof(ipv4_host->sin_addr));
On 2011/03/28 22:01:20, wtc wrote:
> Nit: remove the parentheses in the second argument.
> 
> An experienced system programmer should have no problem
> understanding what &ipv4_host->sin_addr means.

Done.

(This was actually a move from above, I didn't introduce the parenthesis)

[commit-bot: I haz the power, 2011-03-29 01:10:16]

Try job failure for 6719035-7002 on win:
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2011-03-29 04:07:25]

Change committed as 79658