Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 6719022: Fix error in test-reloc-info/Positions. This error caused a failure on Windows 64-bit V8. (Closed)

Created:
9 years, 9 months ago by William Hesse
Modified:
9 years, 7 months ago
Reviewers:
Lasse Reichstein
CC:
v8-dev
Visibility:
Public.

Description

Fix error in test-reloc-info/Positions. This error caused a failure on Windows 64-bit V8. BUG=1267 TEST=test-reloc-info/Positions Committed: http://code.google.com/p/v8/source/detail?r=7302

Patch Set 1 #

Total comments: 1

Patch Set 2 : addressed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -11 lines) Patch
M test/cctest/test-reloc-info.cc View 1 4 chunks +18 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
William Hesse
This test was reading uninitialized data from the buffer using a RelocIterator. Fixed so only ...
9 years, 9 months ago (2011-03-22 11:24:18 UTC) #1
Lasse Reichstein
LGTM http://codereview.chromium.org/6719022/diff/1/test/cctest/test-reloc-info.cc File test/cctest/test-reloc-info.cc (right): http://codereview.chromium.org/6719022/diff/1/test/cctest/test-reloc-info.cc#newcode45 test/cctest/test-reloc-info.cc:45: const int code_size = 10 << 10; Odd ...
9 years, 9 months ago (2011-03-22 11:42:44 UTC) #2
William Hesse
9 years, 9 months ago (2011-03-22 11:48:22 UTC) #3
Changed to 10 * KB.

On 2011/03/22 11:42:44, Lasse Reichstein wrote:
> LGTM
> 
> http://codereview.chromium.org/6719022/diff/1/test/cctest/test-reloc-info.cc
> File test/cctest/test-reloc-info.cc (right):
> 
>
http://codereview.chromium.org/6719022/diff/1/test/cctest/test-reloc-info.cc#...
> test/cctest/test-reloc-info.cc:45: const int code_size = 10 << 10;
> Odd way to write a constant. Why not just 10 * KB, or (if KB isn't available
> here) 10240. Or 100 * 100, to match what is being done below.

Powered by Google App Engine
This is Rietveld 408576698