Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issue 6719005: Cherry-pick vboot_reference files from TOT to support crossystem (Closed)

Created:
9 years, 9 months ago by Randall Spangler
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Bill Richardson
Visibility:
Public.

Description

Cherry-pick vboot_reference files from TOT to support crossystem These files are picked from vboot_reference TOT at this tag: 7141571d55373fc2a84a70b5663409a653f8049d There's about a dozen individual CLs in TOT which this is coalesced from. Rather than attempt to squash all of them, I've just pulled the current versions. This admittedly pulls in more files than I'd like in a single CL. Most of those are inside the firmware subdir, and are required for unit tests (esp. load_kernel_test) to compile but aren't used in the actual OS image. I have NOT pulled in any unreleated script changes, such as Gaurav's changes to the signing scripts. Change-Id: I3521a6eed40ff12c82545f2170090e755d7007fc R=dlaurie@chromium.org,reinauer@chromium.org,puneetster@chromium.org BUG=12904 TEST=manual 1. make && make runtests && make clean 2. emerge-x86-alex vboot_reference, then run the resulting crossystem utility on Alex 0053G1+ firmware Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=85d55e2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1211 lines, -212 lines) Patch
M firmware/Makefile View 2 chunks +19 lines, -0 lines 0 comments Download
M firmware/include/load_firmware_fw.h View 2 chunks +12 lines, -10 lines 0 comments Download
M firmware/include/tlcl.h View 2 chunks +6 lines, -1 line 0 comments Download
M firmware/include/utility.h View 1 chunk +14 lines, -0 lines 0 comments Download
M firmware/include/vboot_nvstorage.h View 4 chunks +20 lines, -7 lines 0 comments Download
M firmware/include/vboot_struct.h View 2 chunks +148 lines, -3 lines 0 comments Download
M firmware/lib/include/rollback_index.h View 2 chunks +6 lines, -2 lines 0 comments Download
A firmware/lib/include/tpm_bootmode.h View 1 chunk +25 lines, -0 lines 0 comments Download
M firmware/lib/rollback_index.c View 7 chunks +67 lines, -70 lines 0 comments Download
A firmware/lib/tpm_bootmode.c View 1 chunk +134 lines, -0 lines 0 comments Download
M firmware/lib/tpm_lite/include/tlcl_structures.h View 1 chunk +5 lines, -0 lines 0 comments Download
M firmware/lib/tpm_lite/tlcl.c View 5 chunks +50 lines, -7 lines 0 comments Download
M firmware/lib/vboot_common.c View 3 chunks +8 lines, -0 lines 0 comments Download
M firmware/lib/vboot_firmware.c View 24 chunks +75 lines, -2 lines 0 comments Download
M firmware/lib/vboot_kernel.c View 26 chunks +171 lines, -34 lines 0 comments Download
M firmware/lib/vboot_nvstorage.c View 3 chunks +15 lines, -17 lines 0 comments Download
M firmware/linktest/main.c View 3 chunks +5 lines, -0 lines 0 comments Download
M firmware/stub/load_firmware_stub.c View 1 chunk +2 lines, -2 lines 0 comments Download
M firmware/stub/utility_stub.c View 3 chunks +12 lines, -1 line 0 comments Download
M host/lib/crossystem.c View 11 chunks +333 lines, -5 lines 0 comments Download
M tests/tpm_lite/timing.c View 4 chunks +13 lines, -5 lines 0 comments Download
M tests/vboot_nvstorage_test.c View 1 chunk +2 lines, -2 lines 0 comments Download
M utility/crossystem_main.c View 7 chunks +58 lines, -42 lines 0 comments Download
M utility/load_kernel_test.c View 1 chunk +2 lines, -2 lines 0 comments Download
M utility/tlcl_generator.c View 2 chunks +8 lines, -0 lines 0 comments Download
M utility/tpmc.c View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Randall Spangler
9 years, 9 months ago (2011-03-21 21:04:33 UTC) #1
Will Drewry
This should probably be tested on Mario before cherry-picking, but otherwise, it makes sense to ...
9 years, 9 months ago (2011-03-21 21:11:30 UTC) #2
Duncan Laurie
LGTM I reviewed a lot of these when they were put into TOT, but adding ...
9 years, 9 months ago (2011-03-21 21:50:04 UTC) #3
Luigi Semenzato
LGTM for the TPM changes. On 2011/03/21 21:50:04, Duncan Laurie wrote: > LGTM > > ...
9 years, 9 months ago (2011-03-21 22:46:57 UTC) #4
puneetster1
9 years, 9 months ago (2011-03-21 23:05:57 UTC) #5
Approved for R11.

On 2011/03/21 22:46:57, Luigi Semenzato wrote:
> LGTM for the TPM changes.
> 
> On 2011/03/21 21:50:04, Duncan Laurie wrote:
> > LGTM
> > 
> > I reviewed a lot of these when they were put into TOT, but adding Luigi to
> > double-check the TPM changes.

Powered by Google App Engine
This is Rietveld 408576698