FTP: Multiple fixes for localized directory listings:

net/ftp/ftp_directory_listing_parser_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/ftp/ftp_directory_listing_parser.h"
 
 #include "base/file_util.h"
 #include "base/format_macros.h"
 #include "base/path_service.h"
 #include "base/string_number_conversions.h"
@@ skipping 28 matching lines @@
     "dir-listing-ls-15",
     "dir-listing-ls-16",
     "dir-listing-ls-17",
     "dir-listing-ls-18",
     "dir-listing-ls-19",
     "dir-listing-ls-20",  // TODO(phajdan.jr): should use windows-1251 encoding.
     "dir-listing-ls-21",  // TODO(phajdan.jr): should use windows-1251 encoding.
     "dir-listing-ls-22",  // TODO(phajdan.jr): should use windows-1251 encoding.
     "dir-listing-ls-23",
     "dir-listing-ls-24",
+    "dir-listing-ls-25",

[gavinp, 2011/03/30 17:14:23]

These filenames should include at least the name of the character set and/or
language we're testing for: so "dir-listing-ls-25-russian", etc...

Even better would be to capture information in the test like the
inversion/noninversion of months in the test...

[Paweł Hajdan Jr., 2011/04/01 15:55:27]

I've added some comments here, not sure how much they're helping. Generally the
listings here test parsing of the _entire_ listing, not any of its "features"
like swapped date columns.

On the other hand, encoding is really one of the things being tested here, and
it indeed may be difficult to recover later (for example, the "file" command
failed to recognize the KOI8-R encoding, saying it's ISO-8859 family; they're
just very similar).

+    "dir-listing-ls-26",
+    "dir-listing-ls-27",
     "dir-listing-netware-1",
     "dir-listing-netware-2",
     "dir-listing-vms-1",
     "dir-listing-vms-2",
     "dir-listing-vms-3",
     "dir-listing-vms-4",
     "dir-listing-vms-5",
     "dir-listing-windows-1",
     "dir-listing-windows-2",
   };
@@ skipping 74 matching lines @@
       EXPECT_EQ(day_of_month, time_exploded.day_of_month);
       EXPECT_EQ(hour, time_exploded.hour);
       EXPECT_EQ(minute, time_exploded.minute);
     }
   }
 }
 
 }  // namespace
 
 }  // namespace net