Issue 6718023: Cleanup of Isolate usage (guided by SunSpider profiling)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6718023: Cleanup of Isolate usage (guided by SunSpider profiling) (Closed)

Created:
9 years, 9 months ago by Dmitry Titov

Modified:
9 years, 7 months ago

Reviewers:
Vitaly Repeshko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Cleanup of Isolate usage (guided by SunSpider profiling) Committed: http://code.google.com/p/v8/source/detail?r=7311

Patch Set 1 #

Total comments: 1

Patch Set 2 : CR feedback #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -39 lines)			Patch
M	src/mark-compact.cc	View		1 chunk	+4 lines, -3 lines	0 comments	Download
M	src/spaces.h	View	1	7 chunks	+13 lines, -7 lines	0 comments	Download
M	src/spaces.cc	View		15 chunks	+34 lines, -29 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vitaly Repeshko

9 years, 9 months ago (2011-03-22 13:53:29 UTC) #3

http://codereview.chromium.org/6718023/diff/1/src/spaces.h
File src/spaces.h (right):

http://codereview.chromium.org/6718023/diff/1/src/spaces.h#newcode1740
src/spaces.h:1740: explicit OldSpaceFreeList(Heap* heap, AllocationSpace owner);
"explicit" no longer required.

Expand Messages | Collapse Messages