Introduce accessors on builtins instance

Introduce accessors on builtins instance and use them to avoid TLS access when getting builtins.

R=vitalyr@chromium.org

Committed: http://code.google.com/p/v8/source/detail?r=7327

[Vitaly Repeshko, 2011-03-22 14:46:20]

http://codereview.chromium.org/6717018/diff/1/src/builtins.cc
File src/builtins.cc (right):

http://codereview.chromium.org/6717018/diff/1/src/builtins.cc#newcode1689
src/builtins.cc:1689: return Handle<Code>(isolate->builtins()->builtin(name),
isolate);
I think we can reuse builtin address to avoid allocating an extra handle slot.

http://codereview.chromium.org/6717018/diff/1/src/builtins.h
File src/builtins.h (right):

http://codereview.chromium.org/6717018/diff/1/src/builtins.h#newcode297
src/builtins.h:297: static Handle<Code> builtin(Name name, Isolate* isolate);
Why you don't want to make this an instance method? "builtin_handle"? Or maybe
rename "Code* builtin(Name name)" to "Code* buildin_code(Name name)" and use
"builtin" here.

[Mads Ager (chromium), 2011-03-22 18:21:45]

On 2011/03/22 14:46:20, Vitaly Repeshko wrote:
> http://codereview.chromium.org/6717018/diff/1/src/builtins.cc
> File src/builtins.cc (right):
> 
> http://codereview.chromium.org/6717018/diff/1/src/builtins.cc#newcode1689
> src/builtins.cc:1689: return Handle<Code>(isolate->builtins()->builtin(name),
> isolate);
> I think we can reuse builtin address to avoid allocating an extra handle slot.

Yes we can. Good idea. Done in the accessors introduced in this upload.
 
> http://codereview.chromium.org/6717018/diff/1/src/builtins.h
> File src/builtins.h (right):
> 
> http://codereview.chromium.org/6717018/diff/1/src/builtins.h#newcode297
> src/builtins.h:297: static Handle<Code> builtin(Name name, Isolate* isolate);
> Why you don't want to make this an instance method? "builtin_handle"? Or maybe
> rename "Code* builtin(Name name)" to "Code* buildin_code(Name name)" and use
> "builtin" here.

As you suggested on IM I have added accessors for the builtins that we can use
instead.

[Vitaly Repeshko, 2011-03-23 12:13:41]

LGTM!

http://codereview.chromium.org/6717018/diff/5001/src/builtins.cc
File src/builtins.cc (right):

http://codereview.chromium.org/6717018/diff/5001/src/builtins.cc#newcode1689
src/builtins.cc:1689: Handle<Code> Builtins::name() {                           
   \
This shouldn't be indented, I think.

http://codereview.chromium.org/6717018/diff/5001/src/builtins.cc#newcode1695
src/builtins.cc:1695: Handle<Code> Builtins::name() {                           
\
Ditto.

[Mads Ager (chromium), 2011-03-23 12:28:06]

http://codereview.chromium.org/6717018/diff/5001/src/builtins.cc
File src/builtins.cc (right):

http://codereview.chromium.org/6717018/diff/5001/src/builtins.cc#newcode1689
src/builtins.cc:1689: Handle<Code> Builtins::name() {                           
   \
On 2011/03/23 12:13:41, Vitaly Repeshko wrote:
> This shouldn't be indented, I think.

Done.

http://codereview.chromium.org/6717018/diff/5001/src/builtins.cc#newcode1695
src/builtins.cc:1695: Handle<Code> Builtins::name() {                           
\
On 2011/03/23 12:13:41, Vitaly Repeshko wrote:
> Ditto.

Done.