Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Side by Side Diff: chrome/browser/ui/webui/options/language_options_interactive_uitest.cc

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/prefs/pref_service.h" 5 #include "base/prefs/pref_service.h"
6 #include "chrome/browser/chrome_notification_types.h" 6 #include "chrome/browser/chrome_notification_types.h"
7 #include "chrome/browser/ui/browser_window.h" 7 #include "chrome/browser/ui/browser_window.h"
8 #include "chrome/browser/ui/chrome_pages.h" 8 #include "chrome/browser/ui/chrome_pages.h"
9 #include "chrome/browser/ui/tabs/tab_strip_model.h" 9 #include "chrome/browser/ui/tabs/tab_strip_model.h"
10 #include "chrome/common/pref_names.h" 10 #include "chrome/common/pref_names.h"
(...skipping 13 matching lines...) Expand all
24 // This class will test the language options settings. 24 // This class will test the language options settings.
25 // This test is part of the interactive_ui_tests isntead of browser_tests 25 // This test is part of the interactive_ui_tests isntead of browser_tests
26 // because it is necessary to emulate pushing a button in order to properly 26 // because it is necessary to emulate pushing a button in order to properly
27 // test accessiblity. 27 // test accessiblity.
28 class LanguageOptionsWebUITest : public InProcessBrowserTest { 28 class LanguageOptionsWebUITest : public InProcessBrowserTest {
29 public: 29 public:
30 LanguageOptionsWebUITest() {} 30 LanguageOptionsWebUITest() {}
31 31
32 // This method will navigate to the language settings page and show 32 // This method will navigate to the language settings page and show
33 // a subset of languages from the list of available languages. 33 // a subset of languages from the list of available languages.
34 virtual void SetUpOnMainThread() override { 34 void SetUpOnMainThread() override {
35 #if defined(OS_CHROMEOS) 35 #if defined(OS_CHROMEOS)
36 auto setting_name = prefs::kLanguagePreferredLanguages; 36 auto setting_name = prefs::kLanguagePreferredLanguages;
37 #else 37 #else
38 auto setting_name = prefs::kAcceptLanguages; 38 auto setting_name = prefs::kAcceptLanguages;
39 #endif 39 #endif
40 40
41 const GURL url = chrome::GetSettingsUrl(chrome::kLanguageOptionsSubPage); 41 const GURL url = chrome::GetSettingsUrl(chrome::kLanguageOptionsSubPage);
42 ui_test_utils::NavigateToURL(browser(), url); 42 ui_test_utils::NavigateToURL(browser(), url);
43 browser()->profile()->GetPrefs()->SetString(setting_name, "en-US,es,fr"); 43 browser()->profile()->GetPrefs()->SetString(setting_name, "en-US,es,fr");
44 } 44 }
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
139 // Make sure that the element is now the button that is next in the tab order. 139 // Make sure that the element is now the button that is next in the tab order.
140 // Checking that the list is no longer selected is not sufficient to validate 140 // Checking that the list is no longer selected is not sufficient to validate
141 // this use case because this test should fail if an item inside the list is 141 // this use case because this test should fail if an item inside the list is
142 // selected. 142 // selected.
143 std::string new_id = GetActiveElementId(); 143 std::string new_id = GetActiveElementId();
144 EXPECT_EQ("language-options-add-button", new_id); 144 EXPECT_EQ("language-options-add-button", new_id);
145 } 145 }
146 146
147 } // namespace language_options_ui_test 147 } // namespace language_options_ui_test
148 148
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698