Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Side by Side Diff: chrome/browser/ui/webui/bidi_checker_web_ui_test.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_WEBUI_BIDI_CHECKER_WEB_UI_TEST_H_ 5 #ifndef CHROME_BROWSER_UI_WEBUI_BIDI_CHECKER_WEB_UI_TEST_H_
6 #define CHROME_BROWSER_UI_WEBUI_BIDI_CHECKER_WEB_UI_TEST_H_ 6 #define CHROME_BROWSER_UI_WEBUI_BIDI_CHECKER_WEB_UI_TEST_H_
7 7
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "chrome/test/base/web_ui_browser_test.h" 9 #include "chrome/test/base/web_ui_browser_test.h"
10 10
(...skipping 12 matching lines...) Expand all
23 virtual void TearDown() override; 23 virtual void TearDown() override;
24 24
25 protected: 25 protected:
26 WebUIBidiCheckerBrowserTest(); 26 WebUIBidiCheckerBrowserTest();
27 27
28 // Runs the Bidi Checker on the given page URL. |is_rtl| should be true when 28 // Runs the Bidi Checker on the given page URL. |is_rtl| should be true when
29 // the active page locale is RTL. 29 // the active page locale is RTL.
30 void RunBidiCheckerOnPage(const std::string& page_url, bool is_rtl); 30 void RunBidiCheckerOnPage(const std::string& page_url, bool is_rtl);
31 31
32 // Setup test path. 32 // Setup test path.
33 virtual void SetUpInProcessBrowserTestFixture() override; 33 void SetUpInProcessBrowserTestFixture() override;
34 34
35 private: 35 private:
36 // The command line args used to run the test before being changed in SetUp(). 36 // The command line args used to run the test before being changed in SetUp().
37 base::CommandLine::StringVector argv_; 37 base::CommandLine::StringVector argv_;
38 }; 38 };
39 39
40 // Base class for BidiChecker-based tests that run with an LTR UI. 40 // Base class for BidiChecker-based tests that run with an LTR UI.
41 class WebUIBidiCheckerBrowserTestLTR : public WebUIBidiCheckerBrowserTest { 41 class WebUIBidiCheckerBrowserTestLTR : public WebUIBidiCheckerBrowserTest {
42 public: 42 public:
43 void RunBidiCheckerOnPage(const std::string& page_url); 43 void RunBidiCheckerOnPage(const std::string& page_url);
44 }; 44 };
45 45
46 // Base class for BidiChecker-based tests that run with an RTL UI. 46 // Base class for BidiChecker-based tests that run with an RTL UI.
47 class WebUIBidiCheckerBrowserTestRTL : public WebUIBidiCheckerBrowserTest { 47 class WebUIBidiCheckerBrowserTestRTL : public WebUIBidiCheckerBrowserTest {
48 public: 48 public:
49 void RunBidiCheckerOnPage(const std::string& page_url); 49 void RunBidiCheckerOnPage(const std::string& page_url);
50 50
51 protected: 51 protected:
52 virtual void SetUpOnMainThread() override; 52 void SetUpOnMainThread() override;
53 virtual void TearDownOnMainThread() override; 53 void TearDownOnMainThread() override;
54 54
55 // The app locale before we change it 55 // The app locale before we change it
56 std::string app_locale_; 56 std::string app_locale_;
57 }; 57 };
58 58
59 #endif // CHROME_BROWSER_UI_WEBUI_BIDI_CHECKER_WEB_UI_TEST_H_ 59 #endif // CHROME_BROWSER_UI_WEBUI_BIDI_CHECKER_WEB_UI_TEST_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698