Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1311)

Side by Side Diff: chrome/browser/ui/website_settings/permission_bubble_manager.cc

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/website_settings/permission_bubble_manager.h" 5 #include "chrome/browser/ui/website_settings/permission_bubble_manager.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/metrics/user_metrics_action.h" 8 #include "base/metrics/user_metrics_action.h"
9 #include "chrome/browser/ui/website_settings/permission_bubble_request.h" 9 #include "chrome/browser/ui/website_settings/permission_bubble_request.h"
10 #include "chrome/common/chrome_switches.h" 10 #include "chrome/common/chrome_switches.h"
11 #include "content/public/browser/browser_thread.h" 11 #include "content/public/browser/browser_thread.h"
12 #include "content/public/browser/navigation_details.h" 12 #include "content/public/browser/navigation_details.h"
13 #include "content/public/browser/user_metrics.h" 13 #include "content/public/browser/user_metrics.h"
14 14
15 namespace { 15 namespace {
16 16
17 class CancelledRequest : public PermissionBubbleRequest { 17 class CancelledRequest : public PermissionBubbleRequest {
18 public: 18 public:
19 explicit CancelledRequest(PermissionBubbleRequest* cancelled) 19 explicit CancelledRequest(PermissionBubbleRequest* cancelled)
20 : icon_(cancelled->GetIconID()), 20 : icon_(cancelled->GetIconID()),
21 message_text_(cancelled->GetMessageText()), 21 message_text_(cancelled->GetMessageText()),
22 message_fragment_(cancelled->GetMessageTextFragment()), 22 message_fragment_(cancelled->GetMessageTextFragment()),
23 user_gesture_(cancelled->HasUserGesture()), 23 user_gesture_(cancelled->HasUserGesture()),
24 hostname_(cancelled->GetRequestingHostname()) {} 24 hostname_(cancelled->GetRequestingHostname()) {}
25 virtual ~CancelledRequest() {} 25 ~CancelledRequest() override {}
26 26
27 virtual int GetIconID() const override { 27 int GetIconID() const override { return icon_; }
28 return icon_; 28 base::string16 GetMessageText() const override { return message_text_; }
29 } 29 base::string16 GetMessageTextFragment() const override {
30 virtual base::string16 GetMessageText() const override {
31 return message_text_;
32 }
33 virtual base::string16 GetMessageTextFragment() const override {
34 return message_fragment_; 30 return message_fragment_;
35 } 31 }
36 virtual bool HasUserGesture() const override { 32 bool HasUserGesture() const override { return user_gesture_; }
37 return user_gesture_; 33 GURL GetRequestingHostname() const override { return hostname_; }
38 }
39 virtual GURL GetRequestingHostname() const override {
40 return hostname_;
41 }
42 34
43 // These are all no-ops since the placeholder is non-forwarding. 35 // These are all no-ops since the placeholder is non-forwarding.
44 virtual void PermissionGranted() override {} 36 void PermissionGranted() override {}
45 virtual void PermissionDenied() override {} 37 void PermissionDenied() override {}
46 virtual void Cancelled() override {} 38 void Cancelled() override {}
47 39
48 virtual void RequestFinished() override { 40 void RequestFinished() override { delete this; }
49 delete this;
50 }
51 41
52 private: 42 private:
53 int icon_; 43 int icon_;
54 base::string16 message_text_; 44 base::string16 message_text_;
55 base::string16 message_fragment_; 45 base::string16 message_fragment_;
56 bool user_gesture_; 46 bool user_gesture_;
57 GURL hostname_; 47 GURL hostname_;
58 }; 48 };
59 49
60 } // namespace 50 } // namespace
(...skipping 346 matching lines...) Expand 10 before | Expand all | Expand 10 after
407 bool PermissionBubbleManager::HasUserGestureRequest( 397 bool PermissionBubbleManager::HasUserGestureRequest(
408 const std::vector<PermissionBubbleRequest*>& queue) { 398 const std::vector<PermissionBubbleRequest*>& queue) {
409 std::vector<PermissionBubbleRequest*>::const_iterator iter; 399 std::vector<PermissionBubbleRequest*>::const_iterator iter;
410 for (iter = queue.begin(); iter != queue.end(); iter++) { 400 for (iter = queue.begin(); iter != queue.end(); iter++) {
411 if ((*iter)->HasUserGesture()) 401 if ((*iter)->HasUserGesture())
412 return true; 402 return true;
413 } 403 }
414 return false; 404 return false;
415 } 405 }
416 406
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698