Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "chrome/browser/ui/cocoa/extensions/extension_action_context_menu_contro ller.h" 5 #import "chrome/browser/ui/cocoa/extensions/extension_action_context_menu_contro ller.h"
6 6
7 #include "base/strings/sys_string_conversions.h" 7 #include "base/strings/sys_string_conversions.h"
8 #include "chrome/browser/extensions/active_script_controller.h" 8 #include "chrome/browser/extensions/active_script_controller.h"
9 #include "chrome/browser/extensions/api/extension_action/extension_action_api.h" 9 #include "chrome/browser/extensions/api/extension_action/extension_action_api.h"
10 #include "chrome/browser/extensions/extension_action_manager.h" 10 #include "chrome/browser/extensions/extension_action_manager.h"
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 public: 47 public:
48 AsyncUninstaller(const Extension* extension, Browser* browser) 48 AsyncUninstaller(const Extension* extension, Browser* browser)
49 : extension_(extension), 49 : extension_(extension),
50 profile_(browser->profile()) { 50 profile_(browser->profile()) {
51 extension_uninstall_dialog_.reset( 51 extension_uninstall_dialog_.reset(
52 extensions::ExtensionUninstallDialog::Create( 52 extensions::ExtensionUninstallDialog::Create(
53 profile_, browser->window()->GetNativeWindow(), this)); 53 profile_, browser->window()->GetNativeWindow(), this));
54 extension_uninstall_dialog_->ConfirmUninstall(extension_); 54 extension_uninstall_dialog_->ConfirmUninstall(extension_);
55 } 55 }
56 56
57 virtual ~AsyncUninstaller() {} 57 ~AsyncUninstaller() override {}
58 58
59 // ExtensionUninstallDialog::Delegate: 59 // ExtensionUninstallDialog::Delegate:
60 virtual void ExtensionUninstallAccepted() override { 60 void ExtensionUninstallAccepted() override {
61 extensions::ExtensionSystem::Get(profile_) 61 extensions::ExtensionSystem::Get(profile_)
62 ->extension_service() 62 ->extension_service()
63 ->UninstallExtension(extension_->id(), 63 ->UninstallExtension(extension_->id(),
64 extensions::UNINSTALL_REASON_USER_INITIATED, 64 extensions::UNINSTALL_REASON_USER_INITIATED,
65 base::Bind(&base::DoNothing), 65 base::Bind(&base::DoNothing),
66 NULL); 66 NULL);
67 } 67 }
68 virtual void ExtensionUninstallCanceled() override {} 68 void ExtensionUninstallCanceled() override {}
69 69
70 private: 70 private:
71 // The extension that's being uninstalled. 71 // The extension that's being uninstalled.
72 const Extension* extension_; 72 const Extension* extension_;
73 73
74 // The current profile. Weak. 74 // The current profile. Weak.
75 Profile* profile_; 75 Profile* profile_;
76 76
77 scoped_ptr<extensions::ExtensionUninstallDialog> extension_uninstall_dialog_; 77 scoped_ptr<extensions::ExtensionUninstallDialog> extension_uninstall_dialog_;
78 78
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
250 return; 250 return;
251 251
252 [ExtensionPopupController showURL:url 252 [ExtensionPopupController showURL:url
253 inBrowser:browser_ 253 inBrowser:browser_
254 anchoredAt:popupPoint 254 anchoredAt:popupPoint
255 arrowLocation:info_bubble::kTopRight 255 arrowLocation:info_bubble::kTopRight
256 devMode:YES]; 256 devMode:YES];
257 } 257 }
258 258
259 @end 259 @end
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698