Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Side by Side Diff: chrome/browser/ui/bookmarks/bookmark_tab_helper.h

Issue 671653002: Standardize usage of virtual/override/final in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_BOOKMARKS_BOOKMARK_TAB_HELPER_H_ 5 #ifndef CHROME_BROWSER_UI_BOOKMARKS_BOOKMARK_TAB_HELPER_H_
6 #define CHROME_BROWSER_UI_BOOKMARKS_BOOKMARK_TAB_HELPER_H_ 6 #define CHROME_BROWSER_UI_BOOKMARKS_BOOKMARK_TAB_HELPER_H_
7 7
8 #include "components/bookmarks/browser/base_bookmark_model_observer.h" 8 #include "components/bookmarks/browser/base_bookmark_model_observer.h"
9 #include "content/public/browser/web_contents_observer.h" 9 #include "content/public/browser/web_contents_observer.h"
10 #include "content/public/browser/web_contents_user_data.h" 10 #include "content/public/browser/web_contents_user_data.h"
(...skipping 19 matching lines...) Expand all
30 public: 30 public:
31 virtual void OnDragEnter(const bookmarks::BookmarkNodeData& data) = 0; 31 virtual void OnDragEnter(const bookmarks::BookmarkNodeData& data) = 0;
32 virtual void OnDragOver(const bookmarks::BookmarkNodeData& data) = 0; 32 virtual void OnDragOver(const bookmarks::BookmarkNodeData& data) = 0;
33 virtual void OnDragLeave(const bookmarks::BookmarkNodeData& data) = 0; 33 virtual void OnDragLeave(const bookmarks::BookmarkNodeData& data) = 0;
34 virtual void OnDrop(const bookmarks::BookmarkNodeData& data) = 0; 34 virtual void OnDrop(const bookmarks::BookmarkNodeData& data) = 0;
35 35
36 protected: 36 protected:
37 virtual ~BookmarkDrag() {} 37 virtual ~BookmarkDrag() {}
38 }; 38 };
39 39
40 virtual ~BookmarkTabHelper(); 40 ~BookmarkTabHelper() override;
41 41
42 void set_delegate(BookmarkTabHelperDelegate* delegate) { 42 void set_delegate(BookmarkTabHelperDelegate* delegate) {
43 delegate_ = delegate; 43 delegate_ = delegate;
44 } 44 }
45 45
46 // It is up to callers to call set_bookmark_drag_delegate(NULL) when 46 // It is up to callers to call set_bookmark_drag_delegate(NULL) when
47 // |bookmark_drag| is deleted since this class does not take ownership of 47 // |bookmark_drag| is deleted since this class does not take ownership of
48 // |bookmark_drag|. 48 // |bookmark_drag|.
49 void set_bookmark_drag_delegate(BookmarkDrag* bookmark_drag) { 49 void set_bookmark_drag_delegate(BookmarkDrag* bookmark_drag) {
50 bookmark_drag_ = bookmark_drag; 50 bookmark_drag_ = bookmark_drag;
51 } 51 }
52 BookmarkDrag* bookmark_drag_delegate() { return bookmark_drag_; } 52 BookmarkDrag* bookmark_drag_delegate() { return bookmark_drag_; }
53 53
54 bool is_starred() const { return is_starred_; } 54 bool is_starred() const { return is_starred_; }
55 55
56 // Returns true if the bookmark bar should be shown detached. 56 // Returns true if the bookmark bar should be shown detached.
57 bool ShouldShowBookmarkBar() const; 57 bool ShouldShowBookmarkBar() const;
58 58
59 private: 59 private:
60 friend class content::WebContentsUserData<BookmarkTabHelper>; 60 friend class content::WebContentsUserData<BookmarkTabHelper>;
61 61
62 explicit BookmarkTabHelper(content::WebContents* web_contents); 62 explicit BookmarkTabHelper(content::WebContents* web_contents);
63 63
64 // Updates the starred state from the BookmarkModel. If the state has changed, 64 // Updates the starred state from the BookmarkModel. If the state has changed,
65 // the delegate is notified. 65 // the delegate is notified.
66 void UpdateStarredStateForCurrentURL(); 66 void UpdateStarredStateForCurrentURL();
67 67
68 // Overridden from BaseBookmarkModelObserver: 68 // Overridden from BaseBookmarkModelObserver:
69 virtual void BookmarkModelChanged() override; 69 void BookmarkModelChanged() override;
70 virtual void BookmarkModelLoaded(BookmarkModel* model, 70 void BookmarkModelLoaded(BookmarkModel* model, bool ids_reassigned) override;
71 bool ids_reassigned) override; 71 void BookmarkNodeAdded(BookmarkModel* model,
72 virtual void BookmarkNodeAdded(BookmarkModel* model, 72 const BookmarkNode* parent,
73 const BookmarkNode* parent, 73 int index) override;
74 int index) override; 74 void BookmarkNodeRemoved(BookmarkModel* model,
75 virtual void BookmarkNodeRemoved(BookmarkModel* model, 75 const BookmarkNode* parent,
76 const BookmarkNode* parent, 76 int old_index,
77 int old_index, 77 const BookmarkNode* node,
78 const BookmarkNode* node, 78 const std::set<GURL>& removed_urls) override;
79 void BookmarkAllUserNodesRemoved(BookmarkModel* model,
79 const std::set<GURL>& removed_urls) override; 80 const std::set<GURL>& removed_urls) override;
80 virtual void BookmarkAllUserNodesRemoved(
81 BookmarkModel* model,
82 const std::set<GURL>& removed_urls) override;
83 81
84 virtual void BookmarkNodeChanged(BookmarkModel* model, 82 void BookmarkNodeChanged(BookmarkModel* model,
85 const BookmarkNode* node) override; 83 const BookmarkNode* node) override;
86 84
87 // Overridden from content::WebContentsObserver: 85 // Overridden from content::WebContentsObserver:
88 virtual void DidNavigateMainFrame( 86 void DidNavigateMainFrame(
89 const content::LoadCommittedDetails& details, 87 const content::LoadCommittedDetails& details,
90 const content::FrameNavigateParams& params) override; 88 const content::FrameNavigateParams& params) override;
91 virtual void DidStartNavigationToPendingEntry( 89 void DidStartNavigationToPendingEntry(
92 const GURL& url, 90 const GURL& url,
93 content::NavigationController::ReloadType reload_type) override; 91 content::NavigationController::ReloadType reload_type) override;
94 92
95 // Whether the current URL is starred. 93 // Whether the current URL is starred.
96 bool is_starred_; 94 bool is_starred_;
97 95
98 BookmarkModel* bookmark_model_; 96 BookmarkModel* bookmark_model_;
99 97
100 // Our delegate, to notify when the url starred changed. 98 // Our delegate, to notify when the url starred changed.
101 BookmarkTabHelperDelegate* delegate_; 99 BookmarkTabHelperDelegate* delegate_;
102 100
103 // The BookmarkDrag is used to forward bookmark drag and drop events to 101 // The BookmarkDrag is used to forward bookmark drag and drop events to
104 // extensions. 102 // extensions.
105 BookmarkDrag* bookmark_drag_; 103 BookmarkDrag* bookmark_drag_;
106 104
107 DISALLOW_COPY_AND_ASSIGN(BookmarkTabHelper); 105 DISALLOW_COPY_AND_ASSIGN(BookmarkTabHelper);
108 }; 106 };
109 107
110 #endif // CHROME_BROWSER_UI_BOOKMARKS_BOOKMARK_TAB_HELPER_H_ 108 #endif // CHROME_BROWSER_UI_BOOKMARKS_BOOKMARK_TAB_HELPER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698