Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 6716020: Rename memory.h to v8memory.h (Closed)

Created:
9 years, 9 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Rename memory.h to v8memory.h This is to avoid name collision with system include file named memory.h causing problems on some platforms. Committed: http://code.google.com/p/v8/source/detail?r=7301

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -98 lines) Patch
M src/arm/frames-arm.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/frames-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/frames-ia32.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/liveedit.cc View 1 1 chunk +1 line, -1 line 0 comments Download
D src/memory.h View 1 chunk +0 lines, -82 lines 0 comments Download
M src/objects-inl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/spaces-inl.h View 1 1 chunk +1 line, -1 line 0 comments Download
A + src/v8memory.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/x64/assembler-x64-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/frames-x64.h View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/gyp/v8.gyp View 1 2 chunks +1 line, -1 line 0 comments Download
M tools/v8.xcodeproj/project.pbxproj View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/visual_studio/v8_base.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M tools/visual_studio/v8_base_arm.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M tools/visual_studio/v8_base_x64.vcproj View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
9 years, 9 months ago (2011-03-22 11:43:20 UTC) #1
Mads Ager (chromium)
9 years, 9 months ago (2011-03-22 11:47:34 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698