Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 6716004: Removing TLS fetches on v8::String API (Closed)

Created:
9 years, 9 months ago by Dmitry Lomov
Modified:
9 years, 7 months ago
Reviewers:
Vitaly Repeshko
CC:
v8-dev
Visibility:
Public.

Description

Removing TLS fetches on v8::String API BUG= TEST=

Patch Set 1 #

Total comments: 1

Patch Set 2 : Additional removal of TLS access in v8::String #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
M src/api.cc View 1 5 chunks +12 lines, -11 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
Dmitry Lomov
Vitaly, could you have a look and see if it is the right way to ...
9 years, 9 months ago (2011-03-21 19:10:46 UTC) #1
Vitaly Repeshko
LGTM. Yes, this seems to be right approach. I'll land Thanks, Vitaly http://codereview.chromium.org/6716004/diff/1/src/api.cc File src/api.cc ...
9 years, 9 months ago (2011-03-21 19:26:47 UTC) #2
Dmitry Lomov
More places
9 years, 9 months ago (2011-03-21 20:20:25 UTC) #3
Vitaly Repeshko
9 years, 9 months ago (2011-03-22 14:48:52 UTC) #4
LGTM! I'll land.


Thanks,
Vitaly

http://codereview.chromium.org/6716004/diff/4001/src/api.cc
File src/api.cc (right):

http://codereview.chromium.org/6716004/diff/4001/src/api.cc#newcode3919
src/api.cc:3919: EnsureInitializedForIsolate(isolate, "v8::String::New()");
The string tags are wrong here.

Powered by Google App Engine
This is Rietveld 408576698