Reimplement Splay Tree in JavaScript (and add unit tests!).

Reimplement Splay Tree in JavaScript (and add unit tests!).

This is the first step in reimplementing tick processing scripts in
JavaScript. The goal is to have the same source both for Dev Tools and
Golem, so Python implementation will be removed to avoid code
duplication.

The implementation follows the Dev Tools style: namespaces and JSDocs
are used.

Committed: http://code.google.com/p/v8/source/detail?r=1709

[Søren Thygesen Gjesse, 2009-04-15 01:11:52]

LGTM

http://codereview.chromium.org/67151/diff/1/3
File test/mjsunit/tools/splaytree.js (right):

http://codereview.chromium.org/67151/diff/1/3#newcode28
Line 28: // Files: tools/splaytree.js
Please add a comment that this is relative to the project root - I confused me
as I was at first thinking that the file was importing itself.

http://codereview.chromium.org/67151/diff/1/4
File tools/splaytree.js (right):

http://codereview.chromium.org/67151/diff/1/4#newcode149
Line 149: goog.structs.SplayTree.prototype.findMin = function() {
Maybe add opt_startNode to match findMax.

[Mikhail Naganov, 2009-04-15 01:22:08]

http://codereview.chromium.org/67151/diff/1/3
File test/mjsunit/tools/splaytree.js (right):

http://codereview.chromium.org/67151/diff/1/3#newcode28
Line 28: // Files: tools/splaytree.js
On 2009/04/15 01:11:52, Søren Gjesse wrote:
> Please add a comment that this is relative to the project root - I confused me
> as I was at first thinking that the file was importing itself.

Done.

http://codereview.chromium.org/67151/diff/1/4
File tools/splaytree.js (right):

http://codereview.chromium.org/67151/diff/1/4#newcode149
Line 149: goog.structs.SplayTree.prototype.findMin = function() {
On 2009/04/15 01:11:52, Søren Gjesse wrote:
> Maybe add opt_startNode to match findMax.
> 

This asymmetry exists because findGreatestLessThan doesn't have a mirror
function. Unless we contribute this code to a JS library, I think this doesn't
matter much.