Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Unified Diff: src/shared/ppapi/build.scons

Issue 6715019: Switching ppapi on nacl side to import chrome side .gyp[i] directly. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/
Patch Set: '' Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/shared/ppapi/nacl.scons » ('j') | src/shared/ppapi/nacl.scons » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/shared/ppapi/build.scons
===================================================================
--- src/shared/ppapi/build.scons (revision 4588)
+++ src/shared/ppapi/build.scons (working copy)
@@ -36,53 +36,18 @@
if env.Bit('windows'):
env.FilterOut(CCFLAGS=['/WX'])
-cpp_sources = [
- # Updated automatically by update-scons.py.
- # From ppapi_cpp.gypi:ppapi_cpp_objects:.*\.cc
- 'cpp/audio.cc',
- 'cpp/audio_config.cc',
- 'cpp/core.cc',
- 'cpp/graphics_2d.cc',
- 'cpp/image_data.cc',
- 'cpp/instance.cc',
- 'cpp/module.cc',
- 'cpp/paint_aggregator.cc',
- 'cpp/paint_manager.cc',
- 'cpp/rect.cc',
- 'cpp/resource.cc',
- 'cpp/url_loader.cc',
- 'cpp/url_request_info.cc',
- 'cpp/url_response_info.cc',
- 'cpp/var.cc',
- 'cpp/dev/buffer_dev.cc',
- 'cpp/dev/context_3d_dev.cc',
- 'cpp/dev/directory_entry_dev.cc',
- 'cpp/dev/directory_reader_dev.cc',
- 'cpp/dev/file_chooser_dev.cc',
- 'cpp/dev/file_io_dev.cc',
- 'cpp/dev/file_ref_dev.cc',
- 'cpp/dev/file_system_dev.cc',
- 'cpp/dev/find_dev.cc',
- 'cpp/dev/font_dev.cc',
- 'cpp/dev/fullscreen_dev.cc',
- 'cpp/dev/graphics_3d_client_dev.cc',
- 'cpp/dev/graphics_3d_dev.cc',
- 'cpp/dev/printing_dev.cc',
- 'cpp/dev/scrollbar_dev.cc',
- 'cpp/dev/selection_dev.cc',
- 'cpp/dev/surface_3d_dev.cc',
- 'cpp/dev/transport_dev.cc',
- 'cpp/dev/url_util_dev.cc',
- 'cpp/dev/video_decoder_dev.cc',
- 'cpp/dev/widget_client_dev.cc',
- 'cpp/dev/widget_dev.cc',
- 'cpp/dev/zoom_dev.cc',
- 'cpp/dev/scriptable_object_deprecated.cc',
- # End ppapi_cpp.gypi
- # Updated automatically by update-scons.py.
- # From ppapi_cpp.gypi:ppapi_cpp:.*\.cc
- 'cpp/ppp_entrypoints.cc',
- # End ppapi_cpp.gypi
- ]
+# Load ppapi_cpp.gypi
+ppapi_cpp_gypi_filename = env.File('#/../ppapi/ppapi_cpp.gypi').path
+ppapi_cpp_gypi = eval(open(ppapi_cpp_gypi_filename).read())
Mark Seaborn 2011/03/22 01:17:27 Doing "eval(e, {})" would be cleaner than "eval(e)
bradn 2011/03/22 01:51:43 Done.
+# Extract ppapi_cpp + ppapi_cpp_objects.
+ppapi_cpp_objects = [t for t in ppapi_cpp_gypi['targets']
Mark Seaborn 2011/03/22 01:17:27 t -> target, perhaps? Instead of x[0], maybe do G
bradn 2011/03/22 01:51:43 Migrated to something with an assert.
+ if t['target_name'] == 'ppapi_cpp_objects'][0]
+ppapi_cpp = [t for t in ppapi_cpp_gypi['targets']
+ if t['target_name'] == 'ppapi_cpp'][0]
+# Combine the .cpp files from there.
+cpp_sources = ([s for s in ppapi_cpp_objects['sources']
Mark Seaborn 2011/03/22 01:17:27 s -> source_file?
bradn 2011/03/22 01:51:43 Done.
+ if s.endswith('.cc')] +
Mark Seaborn 2011/03/22 01:17:27 Indentation is odd here.
bradn 2011/03/22 01:51:43 Restructured.
+ [s for s in ppapi_cpp['sources']
+ if s.endswith('.cc')])
env.DualLibrary('ppapi_cpp', cpp_sources)
« no previous file with comments | « no previous file | src/shared/ppapi/nacl.scons » ('j') | src/shared/ppapi/nacl.scons » ('J')

Powered by Google App Engine
This is Rietveld 408576698