Getting rid of more TLS fetches

Getting rid of more TLS fetches


Adding isolate parameter to ENTER_V8 and friends

BUG=
TEST=

[Dmitry Lomov, 2011-03-22 00:48:10]

I did a pass on api.cc and:
- passed isolate into ENTER_V8 and friends 
- removed fetching isolate from TLS in prologues from API methods on HeapObjects

Results are here:
http://dromaeo.com/?id=134396,134398,134485
134396 is bleeding_edge from today morning
134398 is bleeding_edge@7265 which is before isolate landing
134485 is after these changes

There is some encouraging improvements, but we are not there yet.

[Vitaly Repeshko, 2011-03-22 16:14:25]

http://codereview.chromium.org/6715016/diff/1/src/api.cc
File src/api.cc (right):

http://codereview.chromium.org/6715016/diff/1/src/api.cc#newcode2049
src/api.cc:2049: i::Isolate* isolate = i::Isolate::Current();
I think it's safe to move this to the "else" branch below. The fast case doesn't
require entering the VM.

http://codereview.chromium.org/6715016/diff/1/src/api.cc#newcode2050
src/api.cc:2050: if (IsDeadCheck(i::Isolate::Current(),
"v8::Value::ToString()")) {
Could use "isolate" here.

http://codereview.chromium.org/6715016/diff/1/src/api.cc#newcode2069
src/api.cc:2069: i::Isolate* isolate = i::Isolate::Current();
See above (move to "else").

http://codereview.chromium.org/6715016/diff/1/src/api.cc#newcode2089
src/api.cc:2089: i::Isolate* isolate = i::Isolate::Current();
See above (move to "else").

http://codereview.chromium.org/6715016/diff/1/src/api.cc#newcode2107
src/api.cc:2107: i::Isolate* isolate = i::Isolate::Current();
See above (move to "else").

http://codereview.chromium.org/6715016/diff/1/src/api.cc#newcode2124
src/api.cc:2124: i::Isolate* isolate = i::Isolate::Current();
See above (move to "else").

http://codereview.chromium.org/6715016/diff/1/src/api.cc#newcode2142
src/api.cc:2142: i::Isolate* isolate = i::Isolate::Current();
See above (move to "else").

http://codereview.chromium.org/6715016/diff/1/src/api.cc#newcode2241
src/api.cc:2241: i::Isolate* isolate = i::Isolate::Current();
See above (move to "else").

http://codereview.chromium.org/6715016/diff/1/src/api.cc#newcode2256
src/api.cc:2256: i::Isolate* isolate = i::Isolate::Current();
See above (move to "else").

http://codereview.chromium.org/6715016/diff/1/src/api.cc#newcode2276
src/api.cc:2276: i::Isolate* isolate = i::Isolate::Current();
See above (move to "else").

http://codereview.chromium.org/6715016/diff/1/src/api.cc#newcode2298
src/api.cc:2298: i::Isolate* isolate = i::Isolate::Current();
See above (move to "else").

http://codereview.chromium.org/6715016/diff/1/src/api.cc#newcode2316
src/api.cc:2316: i::Isolate* isolate = i::Isolate::Current();
See above (move to "else").

http://codereview.chromium.org/6715016/diff/1/src/api.cc#newcode2363
src/api.cc:2363: i::Isolate* isolate = i::Isolate::Current();
See above (move to "else").

http://codereview.chromium.org/6715016/diff/1/src/api.cc#newcode2444
src/api.cc:2444: i::Isolate* isolate = i::Isolate::Current();
See above (move to "else").

http://codereview.chromium.org/6715016/diff/1/src/api.cc#newcode3383
src/api.cc:3383: EnsureInitializedForIsolate(str->GetIsolate(),
"v8::String::IsExternal()");
Replace this with IsDeadCheck. If we have a valid string object, then the
isolate must have been initialized already.

http://codereview.chromium.org/6715016/diff/1/src/api.cc#newcode3390
src/api.cc:3390: EnsureInitializedForIsolate(str->GetIsolate(),
See above.

http://codereview.chromium.org/6715016/diff/1/src/api.cc#newcode3413
src/api.cc:3413: EnsureInitializedForIsolate(
See above.

http://codereview.chromium.org/6715016/diff/1/src/api.cc#newcode4046
src/api.cc:4046: if (this->IsExternal()) return false;  // Already an external
string.
It makes sense to inline IsExternal() here to avoid duplicate checks.

http://codereview.chromium.org/6715016/diff/1/src/api.cc#newcode4076
src/api.cc:4076: if (this->IsExternal()) return false;  // Already an external
string.
See above.

http://codereview.chromium.org/6715016/diff/1/src/api.cc#newcode4582
src/api.cc:4582: return i::Isolate::Current()->thread_id();
Could use "isolate".

http://codereview.chromium.org/6715016/diff/1/src/api.cc#newcode4658
src/api.cc:4658: EnsureInitializedForIsolate(isolate,
"v8::String::Utf8Value::Utf8Value()");
See above.

http://codereview.chromium.org/6715016/diff/1/src/api.cc#newcode4686
src/api.cc:4686: EnsureInitializedForIsolate(isolate,
"v8::String::AsciiValue::AsciiValue()");
See above.

http://codereview.chromium.org/6715016/diff/1/src/api.cc#newcode4714
src/api.cc:4714: EnsureInitializedForIsolate(isolate,
"v8::String::Value::Value()");
See above.

[Dmitry Lomov, 2011-03-22 16:36:42]

http://codereview.chromium.org/6715016/diff/1/src/api.cc
File src/api.cc (right):

http://codereview.chromium.org/6715016/diff/1/src/api.cc#newcode2049
src/api.cc:2049: i::Isolate* isolate = i::Isolate::Current();
On 2011/03/22 16:14:25, Vitaly Repeshko wrote:
> I think it's safe to move this to the "else" branch below. The fast case
doesn't
> require entering the VM.

Hmm do you mean to the "else" of obj->IsString()? This would mean we would also
loose logging (the LOG_API bit) - is that OK?

[Vitaly Repeshko, 2011-03-22 16:38:52]

http://codereview.chromium.org/6715016/diff/1/src/api.cc
File src/api.cc (right):

http://codereview.chromium.org/6715016/diff/1/src/api.cc#newcode2049
src/api.cc:2049: i::Isolate* isolate = i::Isolate::Current();
On 2011/03/22 16:36:42, dslomov wrote:
> On 2011/03/22 16:14:25, Vitaly Repeshko wrote:
> > I think it's safe to move this to the "else" branch below. The fast case
> doesn't
> > require entering the VM.
> 
> Hmm do you mean to the "else" of obj->IsString()? This would mean we would
also
> loose logging (the LOG_API bit) - is that OK?

Yes, I don't know of any valid use for LOG_API.

[Dmitry Lomov, 2011-03-22 20:12:36]

Code review feedback addressed