Issue 67141: AtomicString usage improvements in v8 interceptors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 67141: AtomicString usage improvements in v8 interceptors. (Closed)

Created:
11 years, 8 months ago by asargent_no_longer_on_chrome

Modified:
9 years, 7 months ago

Reviewers:
Mike Belshe

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

AtomicString usage improvements in v8 interceptors.

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -6 lines)			Patch
	M	third_party/WebKit/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	third_party/WebKit/WebCore/bindings/v8/custom/V8HTMLDocumentCustom.cpp	View		2 chunks	+6 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

Mike Belshe

11 years, 8 months ago (2009-04-14 20:40:56 UTC) #2

LGTM

You could merge the 2 isntances for AtomicString("all") into one, but that
probably isn't a big deal.