Set Suspend timeout to 30 minutes on AC.

Set Suspend timeout to 30 minutes on AC.

In order to be Energy Star compliant, sleep
mode must be activated after no more than
30 minutes.

Change-Id: I178b5cecd8cfdd66075975106c6a45080ec60d50
Signed-off-by: Benson Leung <bleung@chromium.org>;
Signed-off-by: Sameer Nanda <snanda@chromium.org>;

BUG=chrome-os-partner:2692
TEST=Attach AC power. Let system idle for 30 minutes.
Verify system suspends.

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=461a0cd

[Benson Leung, 2011-03-21 06:25:12]

Guys, let me know if you think this is the right thing to do for meeting Energy
Star requirements or not. There's not much to Energy Star 5.0 except that the
system needs to go to sleep before 30 minutes.

The downside though, is that there's no UI to change this or any of the other
timeouts, so our users may get annoyed by this unless we build in more
video-detector style timeout deferrals during audio playback for example.

[Benson Leung, 2011-03-21 06:26:44]

+mdhayter.

[Ryan, 2011-03-21 17:15:09]

Benson - Please make this a behavior patch (I realize it will be more code than
a basic value change).

Desired behavior:
If playing full-screen video or audio has been active for more than 5 minutes
(will need to tweak this value), then do not go to sleep on AC.

Otherwise, after 30 minutes - go to sleep.

[Sameer Nanda, 2011-03-21 17:34:33]

On 2011/03/21 17:15:09, Ryan wrote:
> Benson - Please make this a behavior patch (I realize it will be more code
than
> a basic value change).
> 
> Desired behavior:
> If playing full-screen video or audio has been active for more than 5 minutes
> (will need to tweak this value), then do not go to sleep on AC.
> 
> Otherwise, after 30 minutes - go to sleep.

Agreed on adding audio + full screen presentation mode. I will add external
monitor detection here as well.  We have bugs open for these for a while and can
bump up the priority.

However, here're some scenarios that will still break as a result of this
change:
1. remote ssh into the machine
2. user monitoring audio beeps from an external trigger such as receiving
IM/email etc. and then becoming active in response to the audio beeps.  If the
system is suspended, such audio beeps will not happen.

Scenario #1 is addressable with a patch to "build_image --dev".

Are you ok with breaking scenario #2?

[Benson Leung, 2011-03-21 17:41:07]

Will also suggested to me that we could add an option in Crosh to adjust the
suspend timeout for the short term. Any thoughts on that?

[Benson Leung, 2011-03-21 17:41:53]

On 2011/03/21 17:15:09, Ryan wrote:
> Benson - Please make this a behavior patch (I realize it will be more code
than
> a basic value change).
> 
> Desired behavior:
> If playing full-screen video or audio has been active for more than 5 minutes
> (will need to tweak this value), then do not go to sleep on AC.
> 
> Otherwise, after 30 minutes - go to sleep.

Ryan : Video is already handled by the video detector. Audio we have planned.

[Sameer Nanda, 2011-03-21 17:57:44]

On 2011/03/21 17:41:07, Benson Leung wrote:
> Will also suggested to me that we could add an option in Crosh to adjust the
> suspend timeout for the short term. Any thoughts on that?
I like this a lot.  This way we have a way out for users that have scenarios we
haven't implemented (yet).

[Ryan, 2011-03-21 18:13:12]

Option 2 is a separate issue which should not affect the 30minutes bar (let's
discuss in person).

For now, let's do 30 min now with Video (already covered as Benson pointed out)
and streaming audio. Noting that audio has been active for >5 min should be a
quick change.

Knowing that Benson and Sameer will follow up on the audio side, this CL LGTM.

[Sameer Nanda, 2011-03-21 18:28:01]

LGTM. We'll resolve audio and other related issues separately.