Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 6714032: Move some files in base to base/memory. (Closed)

Created:
9 years, 9 months ago by levin
Modified:
9 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, cbentzel+watch_chromium.org, brettw-cc_chromium.org, Randy Smith (Not in Mondays), darin-cc_chromium.org, Paweł Hajdan Jr., jshin+watch_chromium.org
Visibility:
Public.

Description

Move some files from base to base/memory. raw_scoped_refptr_mismatch_checker.h ref_counted.cc ref_counted.h ref_counted_memory.cc ref_counted_memory.h ref_counted_unittest.cc scoped_callback_factory.h scoped_comptr_win.h scoped_handle.h scoped_native_library.cc scoped_native_library.h scoped_native_library_unittest.cc scoped_nsobject.h scoped_open_process.h scoped_ptr.h scoped_ptr_unittest.cc scoped_temp_dir.cc scoped_temp_dir.h scoped_temp_dir_unittest.cc scoped_vector.h singleton.h singleton_objc.h singleton_unittest.cc linked_ptr.h linked_ptr_unittest.cc weak_ptr.cc weak_ptr.h weak_ptr_unittest.cc BUG=None TEST=Compile Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79524

Patch Set 1 #

Patch Set 2 : Closer to the final patch. #

Patch Set 3 : Try upload again. #

Patch Set 4 : one more attempt #

Patch Set 5 : only changes in base plus presubmit change #

Patch Set 6 : only base #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+604 lines, -590 lines) Patch
M PRESUBMIT.py View 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M base/atomic_ref_count.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/base.gyp View 1 2 3 4 3 chunks +7 lines, -7 lines 0 comments Download
M base/base.gypi View 1 2 3 4 4 chunks +21 lines, -21 lines 0 comments Download
M base/base_paths_linux.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/callback_internal.h View 1 2 3 4 2 chunks +3 lines, -2 lines 1 comment Download
M base/callback_old.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/callback_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/command_line.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/crypto/capi_util.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/crypto/cssm_init.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/crypto/encryptor_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/crypto/mac_security_services_lock.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/crypto/rsa_private_key.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/crypto/rsa_private_key_mac.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/crypto/rsa_private_key_nss.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/crypto/rsa_private_key_nss_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/crypto/rsa_private_key_openssl.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/crypto/rsa_private_key_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/crypto/rsa_private_key_win.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/crypto/scoped_nss_types.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/crypto/secure_hash_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/crypto/signature_creator_mac.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/crypto/signature_creator_nss.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/crypto/signature_creator_openssl.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/crypto/signature_creator_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/crypto/signature_creator_win.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/crypto/signature_verifier_openssl.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/crypto/symmetric_key_openssl.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/crypto/symmetric_key_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/crypto/symmetric_key_win.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/debug/debugger_posix.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/debug/leak_tracker_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/debug/stack_trace_posix.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/debug/stack_trace_win.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/debug/trace_event.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M base/debug/trace_event_win.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/environment.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/environment_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/file_util.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/file_util_posix.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M base/file_util_proxy.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/file_util_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/file_version_info_unittest.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M base/file_version_info_win.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/global_descriptors_posix.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/hmac.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/hmac_nss.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/hmac_openssl.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/file_util_icu.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M base/i18n/number_formatting.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/time_formatting.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/json/json_reader.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/json/json_reader_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/linux_util.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M base/logging_win.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + base/memory/linked_ptr.h View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
A + base/memory/linked_ptr_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
A + base/memory/memory_debug.h View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
A + base/memory/memory_debug.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
A + base/memory/raw_scoped_refptr_mismatch_checker.h View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
A + base/memory/ref_counted.h View 1 2 3 4 5 4 chunks +5 lines, -5 lines 0 comments Download
A + base/memory/ref_counted.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
A + base/memory/ref_counted_memory.h View 1 2 3 4 5 3 chunks +6 lines, -5 lines 0 comments Download
A + base/memory/ref_counted_memory.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
A + base/memory/ref_counted_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
A + base/memory/scoped_callback_factory.h View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
A + base/memory/scoped_handle.h View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
A + base/memory/scoped_native_library.h View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
A + base/memory/scoped_native_library.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
A + base/memory/scoped_native_library_unittest.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 1 comment Download
A + base/memory/scoped_nsobject.h View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
A + base/memory/scoped_open_process.h View 1 2 3 4 5 2 chunks +4 lines, -3 lines 0 comments Download
A base/memory/scoped_ptr.h View 1 2 3 4 5 1 chunk +383 lines, -0 lines 0 comments Download
A + base/memory/scoped_ptr_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
A + base/memory/scoped_temp_dir.h View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
A + base/memory/scoped_temp_dir.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
A + base/memory/scoped_temp_dir_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
A + base/memory/scoped_vector.h View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
A + base/memory/singleton.h View 1 2 3 4 5 3 chunks +4 lines, -4 lines 0 comments Download
A + base/memory/singleton_objc.h View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
A + base/memory/singleton_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
A + base/memory/weak_ptr.h View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
A + base/memory/weak_ptr.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
A + base/memory/weak_ptr_unittest.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M base/message_loop.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/message_loop_proxy.h View 1 2 3 4 2 chunks +2 lines, -2 lines 1 comment Download
M base/message_loop_proxy_impl_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/message_loop_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/message_pump.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/message_pump_glib.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/message_pump_glib_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/message_pump_libevent.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/metrics/field_trial.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/metrics/histogram.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/metrics/stats_table.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/mime_util_xdg.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M base/nss_util.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/observer_list_threadsafe.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M base/observer_list_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/openssl_util.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M base/pickle_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/platform_file_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/process_util_posix.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/process_util_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/process_util_win.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/process_win.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/scoped_ptr.h View 1 2 3 4 1 chunk +3 lines, -380 lines 1 comment Download
M base/shared_memory_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/stack_container_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/string_util.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/synchronization/condition_variable_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/synchronization/waitable_event.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/sys_info_win.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/task.h View 1 2 3 4 4 chunks +8 lines, -5 lines 1 comment Download
M base/task_queue_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/task_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/test/test_suite.cc View 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/threading/non_thread_safe_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/threading/platform_thread_posix.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/threading/thread_checker_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/threading/thread_collision_warner_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/threading/worker_pool_posix.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M base/threading/worker_pool_posix.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/time_win.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/timer_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/values_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/version_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/win/scoped_comptr.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/win/scoped_comptr_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/win/win_util.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
levin
9 years, 9 months ago (2011-03-24 01:31:08 UTC) #1
brettw
9 years, 9 months ago (2011-03-24 20:37:30 UTC) #2
LGTM

http://codereview.chromium.org/6714032/diff/1369/base/callback_internal.h
File base/callback_internal.h (right):

http://codereview.chromium.org/6714032/diff/1369/base/callback_internal.h#new...
base/callback_internal.h:23: class InvokerStorageBase
This change probably isn't necessary any more

http://codereview.chromium.org/6714032/diff/1369/base/memory/scoped_native_li...
File base/memory/scoped_native_library_unittest.cc (right):

http://codereview.chromium.org/6714032/diff/1369/base/memory/scoped_native_li...
base/memory/scoped_native_library_unittest.cc:25: FilePath
path(base::::GetNativeLibraryName(L"ddraw"));
Delete ::

http://codereview.chromium.org/6714032/diff/1369/base/message_loop_proxy.h
File base/message_loop_proxy.h (right):

http://codereview.chromium.org/6714032/diff/1369/base/message_loop_proxy.h#ne...
base/message_loop_proxy.h:23: MessageLoopProxyTraits> {
Revert this

http://codereview.chromium.org/6714032/diff/1369/base/scoped_ptr.h
File base/scoped_ptr.h (right):

http://codereview.chromium.org/6714032/diff/1369/base/scoped_ptr.h#newcode5
base/scoped_ptr.h:5: // Temporary fix due to third_party expectations.
Can you put a TODO here and list which third_part file depends on this? Some
people do look for this kind of thing and fix them sometimes.

http://codereview.chromium.org/6714032/diff/1369/base/task.h
File base/task.h (right):

http://codereview.chromium.org/6714032/diff/1369/base/task.h#newcode152
base/task.h:152: (base::internal::
Revert this, same for the other cases below

Powered by Google App Engine
This is Rietveld 408576698