git_cl/git_cl.py - Issue 6714008: fix failed rename of args - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(32)

My Issues | Starred Open | Closed | All

Unified Diff: git_cl/git_cl.py

Issue 6714008: fix failed rename of args (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: add tests Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « no previous file | git_cl/test/patch.sh » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: git_cl/git_cl.py

diff --git a/git_cl/git_cl.py b/git_cl/git_cl.py

index 2005c19cd6ef11fe3098129d59006d7483bd17c2..56a2fa6cb8b718dfea61a7365033ad335d0b11b4 100644

--- a/git_cl/git_cl.py

+++ b/git_cl/git_cl.py

@@ -1172,7 +1172,7 @@ def CMDpatch(parser, args):

return 1

issue_arg = args[0]

- if re.match(r'\d+', input):

+ if re.match(r'\d+', issue_arg):

# Input is an issue id. Figure out the URL.

issue = issue_arg

server = settings.GetDefaultServerUrl()

@@ -1188,7 +1188,7 @@ def CMDpatch(parser, args):

match = re.match(r'.*?/issue(\d+)_\d+.diff', issue_url)

if match:

issue = match.group(1)

- url = input

+ url = issue_arg

else:

DieWithError('Must pass an issue ID or full URL for '

'\'Download raw patch set\'')

« no previous file with comments | « no previous file | git_cl/test/patch.sh » ('j') | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698