Issue 6713119: Make 'dangerous download warning' visible in Japanese UI on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6713119: Make 'dangerous download warning' visible in Japanese UI on Windows. (Closed)

Created:
9 years, 9 months ago by jungshik at Google

Modified:
9 years, 7 months ago

Reviewers:
Tom Sepez, Jay Civelli

CC:
chromium-reviews, jshin+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make 'dangerous download warning' visible in Japanese UI on Windows. Use line break iterator to get the splitting of 'dangerous download warning' in Chinese/Japanese/Thai to 2 lines to work correctly. In break_iterator.cc, make WORD_SPACE an alias to WORD_LINE and change the explanation about what it does. No code change is made there. More i18n-oriented tests will be added in the follow-up CL to break_iterator_unittest.cc BUG=3638 TEST=manual: launch Chrome on Windows in Japanese/Thai/Chinese (--lang=ja , th, zh-CN, or zh-TW) and follow the instruction at http://crbug.com/76652 (comment 0). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79584

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -22 lines)			Patch
M	base/i18n/break_iterator.h	View	1	4 chunks	+22 lines, -9 lines	0 comments	Download
M	base/i18n/break_iterator.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/download_item_view.cc	View	1	3 chunks	+33 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Tom Sepez

On 2011/03/25 01:41:56, Jungshik Shin wrote: LGTM. Thanks for the clarifying comments in break_iterator.h.

9 years, 9 months ago (2011-03-25 16:10:01 UTC) #2

LGTM

Expand Messages | Collapse Messages