Moving several chromium presubmit checks into the common pool for use in other

Moving several chromium presubmit checks into the common pool for use in other
projects.

BUG=None
TEST=None

R=erikkay@chromium.org,dpranke@chromium.org,maruel@chromium.org
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79316

[M-A Ruel, 2011-03-24 17:08:04]

+Dirk for owner check.

http://codereview.chromium.org/6713101/diff/1/presubmit_canned_checks.py
File presubmit_canned_checks.py (right):

http://codereview.chromium.org/6713101/diff/1/presubmit_canned_checks.py#newc...
presubmit_canned_checks.py:686: _TEXT_FILES = (
Maybe better to be local variables?

http://codereview.chromium.org/6713101/diff/1/presubmit_canned_checks.py#newc...
presubmit_canned_checks.py:692: r".*? Copyright \(c\) %(year)s The %(project)s
Authors\. "
I prefer ' but I'm silly.

http://codereview.chromium.org/6713101/diff/1/presubmit_canned_checks.py#newc...
presubmit_canned_checks.py:706: if f.LocalPath().endswith('.h') or
f.LocalPath().endswith('.mm'):
source_file_filter should be doing the filtering already.

def local_filter(f):
  return (source_file_filter(x) and
          input_api.os_path.splitext(x.LocalPath())[1] in ('.h', '.mm')))

maybe not that readable though. I don't mind.

http://codereview.chromium.org/6713101/diff/1/presubmit_canned_checks.py#newc...
presubmit_canned_checks.py:711: if len(files):
if files:

http://codereview.chromium.org/6713101/diff/1/presubmit_canned_checks.py#newc...
presubmit_canned_checks.py:733: if len(files):
if files:

http://codereview.chromium.org/6713101/diff/1/presubmit_canned_checks.py#newc...
presubmit_canned_checks.py:766: if project_name is None:
project_name = project_name or 'Chromium'

same for above.

http://codereview.chromium.org/6713101/diff/1/presubmit_canned_checks.py#newc...
presubmit_canned_checks.py:775: # What does this code do?
funny but unnecessary.

http://codereview.chromium.org/6713101/diff/1/presubmit_canned_checks.py#newc...
presubmit_canned_checks.py:786: # TODO(dpranke): enable upload as well
I'm not sure Dirk is ready to enable it for NaCl and others right now.

[bradn, 2011-03-24 17:29:03]

http://codereview.chromium.org/6713101/diff/1/presubmit_canned_checks.py
File presubmit_canned_checks.py (right):

http://codereview.chromium.org/6713101/diff/1/presubmit_canned_checks.py#newc...
presubmit_canned_checks.py:686: _TEXT_FILES = (
On 2011/03/24 17:08:04, Marc-Antoine Ruel wrote:
> Maybe better to be local variables?

Done.

http://codereview.chromium.org/6713101/diff/1/presubmit_canned_checks.py#newc...
presubmit_canned_checks.py:692: r".*? Copyright \(c\) %(year)s The %(project)s
Authors\. "
On 2011/03/24 17:08:04, Marc-Antoine Ruel wrote:
> I prefer ' but I'm silly.

Done.

http://codereview.chromium.org/6713101/diff/1/presubmit_canned_checks.py#newc...
presubmit_canned_checks.py:706: if f.LocalPath().endswith('.h') or
f.LocalPath().endswith('.mm'):
On 2011/03/24 17:08:04, Marc-Antoine Ruel wrote:
> source_file_filter should be doing the filtering already.
> 
> def local_filter(f):
>   return (source_file_filter(x) and
>           input_api.os_path.splitext(x.LocalPath())[1] in ('.h', '.mm')))
> 
> maybe not that readable though. I don't mind.

Done.

http://codereview.chromium.org/6713101/diff/1/presubmit_canned_checks.py#newc...
presubmit_canned_checks.py:711: if len(files):
On 2011/03/24 17:08:04, Marc-Antoine Ruel wrote:
> if files:

Done.

http://codereview.chromium.org/6713101/diff/1/presubmit_canned_checks.py#newc...
presubmit_canned_checks.py:733: if len(files):
On 2011/03/24 17:08:04, Marc-Antoine Ruel wrote:
> if files:

Done.

http://codereview.chromium.org/6713101/diff/1/presubmit_canned_checks.py#newc...
presubmit_canned_checks.py:766: if project_name is None:
On 2011/03/24 17:08:04, Marc-Antoine Ruel wrote:
> project_name = project_name or 'Chromium'
> 
> same for above.

Done.

http://codereview.chromium.org/6713101/diff/1/presubmit_canned_checks.py#newc...
presubmit_canned_checks.py:775: # What does this code do?
On 2011/03/24 17:08:04, Marc-Antoine Ruel wrote:
> funny but unnecessary.

Done.

http://codereview.chromium.org/6713101/diff/1/presubmit_canned_checks.py#newc...
presubmit_canned_checks.py:786: # TODO(dpranke): enable upload as well
On 2011/03/24 17:08:04, Marc-Antoine Ruel wrote:
> I'm not sure Dirk is ready to enable it for NaCl and others right now.

Uh, NaCl's trying it out, that's what's prompted this.
Dirk, does this scare you?

[Dirk Pranke, 2011-03-24 19:52:09]

LGTM.

The patch looks fine; if I were you, though, I'd wait another couple days for
all the bugs to get shaken out and stabilized on Chrome before I turn it on for
NaCl (or V8, if they're even considering it).