Add support for the cgroups config we have in chromeos

Add support for the cgroups config we have in chromeos


BUG=None
TEST=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79308

[agl, 2011-03-24 00:02:08]

http://codereview.chromium.org/6713089/diff/1/base/process_linux.cc
File base/process_linux.cc (right):

http://codereview.chromium.org/6713089/diff/1/base/process_linux.cc#newcode13
base/process_linux.cc:13: 
#if defined(OS_CHROMEOS)

http://codereview.chromium.org/6713089/diff/1/base/process_linux.cc#newcode14
base/process_linux.cc:14: namespace {
An anonymous namespace isn't needed if the variables are static anyway. My
personal preference is for 'static' on the variables.

http://codereview.chromium.org/6713089/diff/1/base/process_linux.cc#newcode16
base/process_linux.cc:16: static bool inited = false;
s/inited/cgroups_inited/

http://codereview.chromium.org/6713089/diff/1/base/process_linux.cc#newcode45
base/process_linux.cc:45: // one for at most single foreground renderer and the
other for all
"one for at most single" <- doesn't read right.

http://codereview.chromium.org/6713089/diff/1/base/process_linux.cc#newcode50
base/process_linux.cc:50: foreground_tasks = FilePath(kForegroundTasks);
This probably is obviously not thread-safe. I guess that GetFileSystemType isn't
instrumented for file access so you can get away with calling it on the I/O
threads without DCHECKing?

I would consider making it #if defined(OS_CHROMEOS) because nobody else is going
to mount cgroups in /tmp.

http://codereview.chromium.org/6713089/diff/1/base/process_linux.cc#newcode64
base/process_linux.cc:64: if (file_util::WriteFile(background_tasks,
pid.c_str(), pid.size()) > 0) {
This doesn't DCHECK on the file checks?

[DaveMoore, 2011-03-24 16:45:17]

http://codereview.chromium.org/6713089/diff/1/base/process_linux.cc
File base/process_linux.cc (right):

http://codereview.chromium.org/6713089/diff/1/base/process_linux.cc#newcode13
base/process_linux.cc:13: 
On 2011/03/24 00:02:08, agl wrote:
> #if defined(OS_CHROMEOS)

Done.

http://codereview.chromium.org/6713089/diff/1/base/process_linux.cc#newcode14
base/process_linux.cc:14: namespace {
On 2011/03/24 00:02:08, agl wrote:
> An anonymous namespace isn't needed if the variables are static anyway. My
> personal preference is for 'static' on the variables.

Done.

http://codereview.chromium.org/6713089/diff/1/base/process_linux.cc#newcode16
base/process_linux.cc:16: static bool inited = false;
On 2011/03/24 00:02:08, agl wrote:
> s/inited/cgroups_inited/

Done.

http://codereview.chromium.org/6713089/diff/1/base/process_linux.cc#newcode45
base/process_linux.cc:45: // one for at most single foreground renderer and the
other for all
On 2011/03/24 00:02:08, agl wrote:
> "one for at most single" <- doesn't read right.

Done.

http://codereview.chromium.org/6713089/diff/1/base/process_linux.cc#newcode50
base/process_linux.cc:50: foreground_tasks = FilePath(kForegroundTasks);
On 2011/03/24 00:02:08, agl wrote:
> This probably is obviously not thread-safe. I guess that GetFileSystemType
isn't
> instrumented for file access so you can get away with calling it on the I/O
> threads without DCHECKing?
> 
> I would consider making it #if defined(OS_CHROMEOS) because nobody else is
going
> to mount cgroups in /tmp.

Done.

http://codereview.chromium.org/6713089/diff/1/base/process_linux.cc#newcode64
base/process_linux.cc:64: if (file_util::WriteFile(background_tasks,
pid.c_str(), pid.size()) > 0) {
I moved the in child_process_launcher to the PROCESS_LAUNCHER thread. I did this
for all platforms. I can limit it to cros if you want, but it seemed beneficial
for all (adds some latency to the priority changing but does make the call on
the UI thread).

On 2011/03/24 00:02:08, agl wrote:
> This doesn't DCHECK on the file checks?

[agl, 2011-03-24 16:54:46]

LGTM