Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 6713049: Fix numerous style nits and inconsistencies in mod_image_for_test.sh (Closed)

Created:
9 years, 9 months ago by jrbarnette
Modified:
9 years, 6 months ago
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Fix numerous style nits and inconsistencies in mod_image_for_test.sh BUG=none TEST=build and boot a factory test image Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=68fc75f

Patch Set 1 #

Patch Set 2 : Exclude the opening boilerplate from style fixes #

Patch Set 3 : More nit fixes for consistency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -67 lines) Patch
M mod_image_for_test.sh View 1 2 10 chunks +62 lines, -67 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jrbarnette
This is in preparation for a change to support factory test image generation improvements. The ...
9 years, 9 months ago (2011-03-18 21:02:56 UTC) #1
jrbarnette
Added a few more nit fixes
9 years, 9 months ago (2011-03-18 21:36:54 UTC) #2
Vince Laviano
9 years, 9 months ago (2011-03-18 21:49:26 UTC) #3
On 2011/03/18 21:36:54, jrbarnette wrote:
> Added a few more nit fixes

LGTM

Powered by Google App Engine
This is Rietveld 408576698