Tweak commit interval for ScheduleSavePersistentPrefs.

chrome/common/important_file_writer.cc

-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/important_file_writer.h"
 
 #include <stdio.h>
 
 #include <string>
 
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/logging.h"
 #include "base/message_loop_proxy.h"
 #include "base/string_number_conversions.h"
 #include "base/task.h"
 #include "base/threading/thread.h"
 #include "base/time.h"
 
 using base::TimeDelta;
 
 namespace {
 
-const int kDefaultCommitIntervalMs = 10000;
+#if defined(OFFICIAL_BUILD) || defined(GOOGLE_CHROME_BUILD)

[brettw, 2011/03/21 05:59:31]

This seems like a much much worse idea than NDEBUG vs DEBUG. The point is that
the different behavior makes it hard to find bugs. Now we have something that
real users will run but almost no developer runs in their development
environment.

[Denis Lagno, 2011/03/21 13:07:21]

another attempt..

+// 2 seconds interval provides reasonable optimization by coalescing burst of
+// writes yet this value is reasonably low to be safe.
+const int kDefaultCommitIntervalMs = 2000;
+#else
+// For development builds we increase commit interval in order to ease
+// manifestation of bugs caused by some exit path failing to commit pending
+// writes.
+const int kDefaultCommitIntervalMs = 60000;
+#endif
 
 class WriteToDiskTask : public Task {
  public:
   WriteToDiskTask(const FilePath& path, const std::string& data)
       : path_(path),
         data_(data) {
   }
 
   virtual void Run() {
     // Write the data to a temp file then rename to avoid data loss if we crash
@@ skipping 105 matching lines @@
   DCHECK(serializer_);
   std::string data;
   if (serializer_->SerializeData(&data)) {
     WriteNow(data);
   } else {
     LOG(WARNING) << "failed to serialize data to be saved in "
                  << path_.value();
   }
   serializer_ = NULL;
 }