Provide lazy CommitPendingWrites in addition to eager SavePersistentPrefs.

chrome/browser/chromeos/cros/login_library.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/cros/login_library.h"
 
 #include "base/message_loop.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chromeos/cros/cros_library.h"
 #include "chrome/browser/chromeos/login/signed_settings_temp_storage.h"
@@ skipping 115 matching lines @@
     return chromeos::StopSession("");
   }
 
   bool RestartEntd() {
     return chromeos::RestartEntd();
   }
 
   bool RestartJob(int pid, const std::string& command_line) {
     if (g_browser_process && g_browser_process->local_state()) {
       // XXX: normally this call must not be needed, however it turned out that
-      // without this explicit call to SavePersistentPrefs it is possible for
-      // preferences to be lost. See http://crosbug.com/13102
-      g_browser_process->local_state()->SavePersistentPrefs();
+      // without explicit write it is possible for preferences to be lost.
+      // See http://crosbug.com/13102
+      g_browser_process->local_state()->CommitPendingWrites();
     }
     return chromeos::RestartJob(pid, command_line.c_str());

[Mattias Nissler (ping if slow), 2011/03/22 16:56:20]

On which thread does this run? The CommitPendingWrites runs on the file thread,
so we could race here, killing chrome before the write task finishes.

[Denis Lagno, 2011/03/22 16:58:12]

absoulutely.  I am adding notification to fix this.

[Denis Lagno, 2011/03/22 17:08:40]

OTOH it looks like RestartJob is invoked by sending dbus message, so there is
chance it is safe:)

[Mattias Nissler (ping if slow), 2011/03/22 17:27:02]

Does that mean you're willing to take chances? ;)

I don't feel strong about what we end up with as long as we actually fix the
problem in a reliable way.

[Denis Lagno, 2011/03/23 14:37:43]

Done.

   }
 
  private:
   static void Handler(void* object, const OwnershipEvent& event) {
     LoginLibraryImpl* self = static_cast<LoginLibraryImpl*>(object);
     switch (event) {
       case SetKeySuccess:
         self->CompleteSetOwnerKey(true);
         break;
       case SetKeyFailure:
@@ skipping 127 matching lines @@
 
 // static
 LoginLibrary* LoginLibrary::GetImpl(bool stub) {
   if (stub)
     return new LoginLibraryStubImpl();
   else
     return new LoginLibraryImpl();
 }
 
 }  // namespace chromeos