Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: views/events/event.h

Issue 6713027: Add GetCharacter() and GetUnmodifiedCharacter() methods to views::Event. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | views/events/event.cc » ('j') | views/events/event.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: views/events/event.h
diff --git a/views/events/event.h b/views/events/event.h
index 4173d5382cacc0d3b7dd744cb39121192cb06077..a52e6141c301d28efb9eedf6dc392a34cc6fad71 100644
--- a/views/events/event.h
+++ b/views/events/event.h
@@ -289,14 +289,26 @@ class KeyEvent : public Event {
// Creates a new KeyEvent synthetically (i.e. not in response to an input
// event from the host environment). This is typically only used in testing as
// some metadata obtainable from the underlying native event is not present.
- // TODO(beng): see if we can kill this.
+ // It's also used by input methods to fabricate keyboard events.
KeyEvent(ui::EventType type,
ui::KeyboardCode key_code,
int event_flags);
ui::KeyboardCode key_code() const { return key_code_; }
+ // Gets the character generated by this key event. It only supports Unicode
+ // BMP characters.
+ uint16 GetCharacter() const;
+
+ // Gets the character generated by this key event ignoring concurrently-held
+ // modifiers (except shift).
+ uint16 GetUnmodifiedCharacter() const;
+
private:
+ // A helper function to get the character generated by a key event in a
+ // platform independent way. It supports control characters as well.
+ static uint16 GetCharacterFromKeyCode(ui::KeyboardCode key_code, int flags);
+
ui::KeyboardCode key_code_;
DISALLOW_COPY_AND_ASSIGN(KeyEvent);
« no previous file with comments | « no previous file | views/events/event.cc » ('j') | views/events/event.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698