Add GetCharacter() and GetUnmodifiedCharacter() methods to views::Event.

views/events/event.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef VIEWS_EVENTS_EVENT_H_
 #define VIEWS_EVENTS_EVENT_H_
 #pragma once
 
 #include "base/basictypes.h"
 #include "base/time.h"
@@ skipping 271 matching lines @@
 //
 ////////////////////////////////////////////////////////////////////////////////
 class KeyEvent : public Event {
  public:
   explicit KeyEvent(NativeEvent native_event);
   KeyEvent(NativeEvent2 native_event_2, FromNativeEvent2 from_native);
 
   // Creates a new KeyEvent synthetically (i.e. not in response to an input
   // event from the host environment). This is typically only used in testing as
   // some metadata obtainable from the underlying native event is not present.
-  // TODO(beng): see if we can kill this.
+  // It's also used by input methods to fabricate keyboard events.
   KeyEvent(ui::EventType type,
            ui::KeyboardCode key_code,
            int event_flags);
 
   ui::KeyboardCode key_code() const { return key_code_; }
 
+  // Gets the character generated by this key event. It only supports Unicode
+  // BMP characters.

[oshima, 2011/03/21 18:35:42]

What do we do for non-BMP? 

[James Su, 2011/03/21 18:59:22]

non-BMP characters could be input via TextInputClient::InsertText().

And seems that there is no keyboard layout supporting non-BMP characters. At
least I don't know.

I was thinking to string16 here, but I'm skeptical if it's a good idea to add
such dependency.

+  uint16 GetCharacter() const;
+
+  // Gets the character generated by this key event ignoring concurrently-held
+  // modifiers (except shift).
+  uint16 GetUnmodifiedCharacter() const;
+
  private:
+  // A helper function to get the character generated by a key event in a
+  // platform independent way. It supports control characters as well.
+  // It assumes a US keyboard layout is used, so it may only be used when there
+  // is no native event or no better way to get the character.

[oshima, 2011/03/21 18:35:42]

I indeed assume us keyboard, but it's still not clear why we need or when this
is usefl. Can you clarify?

[James Su, 2011/03/21 18:59:22]

Key events generated by virtual keyboard or input method won't have
native_event. This method is mainly for those kind of events.

+  static uint16 GetCharacterFromKeyCode(ui::KeyboardCode key_code, int flags);
+
   ui::KeyboardCode key_code_;
 
   DISALLOW_COPY_AND_ASSIGN(KeyEvent);
 };
 
 ////////////////////////////////////////////////////////////////////////////////
 //
 // MouseWheelEvent class
 //
 // A MouseWheelEvent is used to propagate mouse wheel user events.
@@ skipping 52 matching lines @@
 
   // Bitmask of supported ui::DragDropTypes::DragOperation by the source.
   int source_operations_;
 
   DISALLOW_COPY_AND_ASSIGN(DropTargetEvent);
 };
 
 }  // namespace views
 
 #endif  // VIEWS_EVENTS_EVENT_H_