chrome/browser/renderer_host/download_throttling_resource_handler.h - Issue 6713008: Don't destroy a request while it is being processed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/download_throttling_resource_handler.h

Issue 6713008: Don't destroy a request while it is being processed (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: . Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/download_request_limiter_unittest.cc ('k') | chrome/browser/renderer_host/download_throttling_resource_handler.cc » ('j') | chrome/browser/renderer_host/download_throttling_resource_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_host/download_throttling_resource_handler.h

diff --git a/chrome/browser/renderer_host/download_throttling_resource_handler.h b/chrome/browser/renderer_host/download_throttling_resource_handler.h

index 4e10c0dff4b23eb98149745c4392f9b0ddc45d4b..1fab3eaf01f9145dfe2b3925f67114b8f4f57858 100644

--- a/chrome/browser/renderer_host/download_throttling_resource_handler.h

+++ b/chrome/browser/renderer_host/download_throttling_resource_handler.h

@@ -58,7 +58,6 @@ class DownloadThrottlingResourceHandler

// DownloadRequestLimiter::Callback implementation:

virtual void CancelDownload();

virtual void ContinueDownload();

- virtual int GetRequestId();

private:

virtual ~DownloadThrottlingResourceHandler();

@@ -91,6 +90,10 @@ class DownloadThrottlingResourceHandler

// we ignore one of them.

bool ignore_on_read_complete_;

+ // Have we received OnRequestClosed()? If so, we shouldn't act on

+ // CancelDownload()/ContinueDownload().

+ bool request_closed_;

DISALLOW_COPY_AND_ASSIGN(DownloadThrottlingResourceHandler);

};