Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3824)

Unified Diff: chrome/browser/download/download_request_limiter.h

Issue 6713008: Don't destroy a request while it is being processed (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: . Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/download_request_limiter.h
diff --git a/chrome/browser/download/download_request_limiter.h b/chrome/browser/download/download_request_limiter.h
index 1caae9a1e6b9f77f94807555005ff5323e005258..02817504c9f24347562bc7f22611e800d2833bba 100644
--- a/chrome/browser/download/download_request_limiter.h
+++ b/chrome/browser/download/download_request_limiter.h
@@ -59,7 +59,6 @@ class DownloadRequestLimiter
public:
virtual void ContinueDownload() = 0;
virtual void CancelDownload() = 0;
- virtual int GetRequestId() = 0;
protected:
virtual ~Callback() {}
@@ -178,6 +177,7 @@ class DownloadRequestLimiter
// the caller to ensure the callback is valid until the request is complete.
void CanDownloadOnIOThread(int render_process_host_id,
int render_view_id,
+ int request_id,
Callback* callback);
// Invoked when the user presses the mouse, enter key or space bar. This may
@@ -218,11 +218,13 @@ class DownloadRequestLimiter
// tab and invokes CanDownloadImpl.
void CanDownload(int render_process_host_id,
int render_view_id,
+ int request_id,
Callback* callback);
// Does the work of updating the download status on the UI thread and
// potentially prompting the user.
void CanDownloadImpl(TabContents* originating_tab,
+ int request_id,
Callback* callback);
// Invoked on the UI thread. Schedules a call to NotifyCallback on the io

Powered by Google App Engine
This is Rietveld 408576698