Issue 6713004: Shorten bail out checks when calling code which can fail.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6713004: Shorten bail out checks when calling code which can fail. (Closed)

Created:
9 years, 9 months ago by antonm

Modified:
9 years, 4 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Shorten bail out checks when calling code which can fail. Committed: http://code.google.com/p/v8/source/detail?r=7303

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -138 lines)			Patch
M	src/arm/stub-cache-arm.cc	View	1	12 chunks	+24 lines, -46 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View	1	12 chunks	+24 lines, -48 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	1	11 chunks	+22 lines, -44 lines	0 comments	Download

Total messages: 4 (0 generated)

antonm

Mads, stupid cleanup change. I am not sure macro is that good---people will forget to ...

9 years, 9 months ago (2011-03-17 18:11:41 UTC) #1

Mads Ager (chromium)

I don't like replacing this with a macro much. The code as is is not ...

9 years, 9 months ago (2011-03-21 07:36:51 UTC) #2

antonm

As discussed on IM, just shorten miss branch generation sequence.

9 years, 9 months ago (2011-03-21 21:13:18 UTC) #3

LGTM