Issue 6713003: Update EbuildIpcDaemon to open files as non-blocking.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6713003: Update EbuildIpcDaemon to open files as non-blocking. (Closed)

Created:
9 years, 9 months ago by davidjames

Modified:
9 years, 4 months ago

Reviewers:
zmedico, zmedico

CC:
chromium-os-reviews_chromium.org

Base URL:
http://git.chromium.org/git/portage_tool.git@cros-2.1.9

Visibility:
Public.

Description

Update EbuildIpcDaemon to open files as non-blocking. This prevents the situation where we block on opening the file descriptor. Change-Id: I5f018ba3f17b6d73f391b676fd4061f299916ad1 R=zmedico@gentoo.org BUG= TEST=

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -9 lines)			Patch
	M	bin/ebuild-ipc.py	View		3 chunks	+6 lines, -6 lines	0 comments	Download
	M	pym/_emerge/EbuildIpcDaemon.py	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

zmedico

It looks good except that ebuild-ipc.py needs to open input_file with O_NONBLOCK. That's how we ...

9 years, 9 months ago (2011-03-17 19:14:29 UTC) #1

zmedico

9 years, 9 months ago (2011-03-17 21:42:50 UTC) #2

I've got the essence of you patch in these 2 commits:

http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=eff879ff...
http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=a81df31c...

Expand Messages | Collapse Messages