Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 6712062: Fix DevTools CPU profiler after isolates merge. (Closed)

Created:
9 years, 9 months ago by mnaganov (inactive)
Modified:
9 years, 7 months ago
Reviewers:
Vitaly Repeshko
CC:
v8-dev
Visibility:
Public.

Description

Fix DevTools CPU profiler after isolates merge. There was an obvious bug with missing call to SamplerRegistry::GetState. I've also updated CpuProfiler to avoid stopping sampler, if it didn't started it. R=vitalyr@chromium.org BUG=none TEST=none Committed: http://code.google.com/p/v8/source/detail?r=7293

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M src/cpu-profiler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/cpu-profiler.cc View 3 chunks +9 lines, -2 lines 0 comments Download
M src/platform-linux.cc View 1 chunk +1 line, -0 lines 1 comment Download
M src/platform-win32.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mnaganov (inactive)
I think, CPUProfiler should have its own Sampler, but let's first introduce a simple fix.
9 years, 9 months ago (2011-03-21 16:17:34 UTC) #1
Vitaly Repeshko
LGTM, thanks! http://codereview.chromium.org/6712062/diff/1/src/platform-linux.cc File src/platform-linux.cc (right): http://codereview.chromium.org/6712062/diff/1/src/platform-linux.cc#newcode953 src/platform-linux.cc:953: state = SamplerRegistry::GetState(); *Facepalm* But please fix ...
9 years, 9 months ago (2011-03-21 17:16:10 UTC) #2
mnaganov (inactive)
9 years, 9 months ago (2011-03-21 17:37:36 UTC) #3
On 2011/03/21 17:16:10, Vitaly Repeshko wrote:
> LGTM, thanks!
> 
> http://codereview.chromium.org/6712062/diff/1/src/platform-linux.cc
> File src/platform-linux.cc (right):
> 
> http://codereview.chromium.org/6712062/diff/1/src/platform-linux.cc#newcode953
> src/platform-linux.cc:953: state = SamplerRegistry::GetState();
> *Facepalm*
> 
> But please fix it in a slightly different way:
> SamplerRegistry::State state;
> while ((state = SamplerRegistry::GetState()) !=
> SamplerRegistry::HAS_NO_SAMPLERS) { ... }
> 

Right. I missed 'continue' statements. Corrected.

> platform-macos.cc also needs to be fixed.

Powered by Google App Engine
This is Rietveld 408576698