Follow jsc on not throwing when trying to add a property to a non-extensible object.

Follow jsc on not throwing when trying to add a property to a non-extensible object.

This change makes us compatible with Safari on not throwing when trying to add a property to a non-extensible object. 
Committed: http://code.google.com/p/v8/source/detail?r=7379

[Rico, 2011-03-21 14:25:32]

Martin, please especially notice my change to test/mjsunit/strict-mode.js
I think this is right since the ThrowTypeError object is NOT in strict mode, and
therefore we should not throw in the extensible case.

[MarkM, 2011-03-21 15:38:08]

For non-strict code, this testing change seems correct. Non-strict code should
indeed not throw on a failed assignment. But strict code should, both according
to the spec and according to jsc. (I just tried in Safari 5.0.4 (5533.20.27,
r80833)). Of the changed tests, their text prior to this change look like valid
tests of what the strict mode behavior should be.

[Martin Maly, 2011-03-21 20:38:35]

LGTM, feel free to use or discard my comment below.

Cheers!
Martin

http://codereview.chromium.org/6712059/diff/1/test/mjsunit/strict-mode.js
File test/mjsunit/strict-mode.js (right):

http://codereview.chromium.org/6712059/diff/1/test/mjsunit/strict-mode.js#new...
test/mjsunit/strict-mode.js:987: assertEquals(pill.value, undefined);
This is alright. We could also have:

assertThrows(function() { 'use strict'; pill.property = "value"; }, TypeError);

either instead or in addition to your check. I am fine with either option. The
paranoid me would go for both :)