Implement easy GPU feature status summary.

content/browser/gpu_blacklist.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/gpu_blacklist.h"
 
 #include "base/json/json_reader.h"
 #include "base/logging.h"
 #include "base/string_number_conversions.h"
 #include "base/string_piece.h"
@@ skipping 661 matching lines @@
 void GpuBlacklist::GetGpuFeatureFlagEntries(
     GpuFeatureFlags::GpuFeatureType feature,
     std::vector<uint32>& entry_ids) const {
   entry_ids.clear();
   for (size_t i = 0; i < active_entries_.size(); ++i) {
     if ((feature & active_entries_[i]->GetGpuFeatureFlags().flags()) != 0)
       entry_ids.push_back(active_entries_[i]->id());
   }
 }
 
-Value* GpuBlacklist::GetBlacklistingReasons() const {
-  ListValue* reasons = new ListValue();
-  for (size_t i = 0; i < active_entries_.size(); ++i) {
-    DictionaryValue* reason = new DictionaryValue();
-    reason->SetString("description", active_entries_[i]->description());
+Value* GpuBlacklist::GetStatus() const {
+  DictionaryValue* status = new DictionaryValue();
 
-    ListValue* cr_bugs = new ListValue();
-    for (size_t j = 0; j < active_entries_[i]->cr_bugs().size(); ++j)
-      cr_bugs->Append(Value::CreateIntegerValue(
-          active_entries_[i]->cr_bugs()[j]));
-    reason->Set("cr_bugs", cr_bugs);
+  // build the feature_status field
+  {
+    ListValue* feature_status_list = new ListValue();
+    // Iterate over all feature bits in kGpuFeatureAll and set feature status
+    // for each one.
+    for (size_t i = 0; i < sizeof(GpuFeatureFlags::GpuFeatureType) * 8; ++i) {
+      GpuFeatureFlags::GpuFeatureType feature =
+          static_cast<GpuFeatureFlags::GpuFeatureType>(1 << i);
+      if (!(feature & GpuFeatureFlags::kGpuFeatureAll))
+        continue;
 
-    ListValue* webkit_bugs = new ListValue();
-    for (size_t j = 0; j < active_entries_[i]->webkit_bugs().size(); ++j)
-      webkit_bugs->Append(Value::CreateIntegerValue(
-          active_entries_[i]->webkit_bugs()[j]));
-    reason->Set("webkit_bugs", webkit_bugs);
+      DictionaryValue* feature_status = new DictionaryValue();
 
-    reasons->Append(reason);
+      std::string feature_name(
+          GpuFeatureFlags::GpuFeatureTypeToUserFriendlyString(feature));
+      feature_status->SetString("name", feature_name);
+
+      // figure out if the feature is on or off
+      bool flagged = false;
+      for (size_t i = 0; i < active_entries_.size(); ++i) {
+        if (active_entries_[i]->GetGpuFeatureFlags().flags() & feature)
+          flagged |= true;

[zmo, 2011/04/07 20:46:06]

should this be flagged = (flagged || true)?  | and || are different.

+      }
+
+      feature_status->SetBoolean("enabled", !flagged);
+
+      feature_status_list->Append(feature_status);
+    }
+    status->Set("featureStatus", feature_status_list);
   }
-  return reasons;
+
+  // build the problems list
+  {
+    ListValue* problem_list = new ListValue();
+    for (size_t i = 0; i < active_entries_.size(); ++i) {
+      GpuBlacklistEntry* entry = active_entries_[i];
+      DictionaryValue* problem = new DictionaryValue();
+
+      problem->SetString("description", entry->description());
+
+      ListValue* cr_bugs = new ListValue();
+      for (size_t j = 0; j < entry->cr_bugs().size(); ++j)
+        cr_bugs->Append(Value::CreateIntegerValue(
+            entry->cr_bugs()[j]));
+      problem->Set("crBugs", cr_bugs);
+
+      ListValue* webkit_bugs = new ListValue();
+      for (size_t j = 0; j < entry->webkit_bugs().size(); ++j)
+        webkit_bugs->Append(Value::CreateIntegerValue(
+            entry->webkit_bugs()[j]));
+      problem->Set("webkitBugs", webkit_bugs);
+
+      problem_list->Append(problem);
+    }
+    status->Set("problems", problem_list);
+  }
+  return status;
 }
 
 uint32 GpuBlacklist::max_entry_id() const {
   return max_entry_id_;
 }
 
 bool GpuBlacklist::GetVersion(uint16* major, uint16* minor) const {
   DCHECK(major && minor);
   *major = 0;
   *minor = 0;
@@ skipping 39 matching lines @@
   return kOsUnknown;
 #endif
 }
 
 void GpuBlacklist::Clear() {
   for (size_t i = 0; i < blacklist_.size(); ++i)
     delete blacklist_[i];
   blacklist_.clear();
   active_entries_.clear();
 }