Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Issue 6712045: Fix Win64 build after isolates merge. (Closed)

Created:
9 years, 9 months ago by Dmitry Titov
Modified:
9 years, 7 months ago
Reviewers:
Vitaly Repeshko
CC:
v8-dev
Visibility:
Public.

Description

Fix Win64 build after isolates merge. Need to add -DWIN32 since the include structure changed.w Committed: http://code.google.com/p/v8/source/detail?r=7272

Patch Set 1 #

Patch Set 2 : Fix Win64 build after isolates merge. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M SConstruct View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Dmitry Titov
9 years, 9 months ago (2011-03-18 21:34:52 UTC) #1
Dmitry Titov
TBR=vitalyr
9 years, 9 months ago (2011-03-18 21:35:01 UTC) #2
Vitaly Repeshko
9 years, 9 months ago (2011-03-18 22:31:28 UTC) #3
LGTM. Oh, nastiness. We need to clean up shell.cc. I'll file a bug.


-- Vitaly

Powered by Google App Engine
This is Rietveld 408576698