Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 6712040: Removed static variable for histograms to avoid race with... (Closed)

Created:
9 years, 9 months ago by ramant (doing other things)
Modified:
9 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, cbentzel+watch_chromium.org, jam
Visibility:
Public.

Description

Removed static variable for histograms to avoid race with histogram initialization across threads. BUG=76092 TEST=histogram unit tests. Sync tests R=jar Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78809

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M chrome/browser/net/url_info.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/buffered_resource_handler.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/base/mime_sniffer.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M net/disk_cache/histogram_macros.h View 1 2 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ramant (doing other things)
Hi Jim and Ricardo, Removed the static from histogram's FactoryGet call (or the macros that ...
9 years, 9 months ago (2011-03-18 20:53:31 UTC) #1
rvargas (doing something else)
LGTM to the change... but I would prefer to know if this is really an ...
9 years, 9 months ago (2011-03-18 21:01:39 UTC) #2
jar (doing other things)
9 years, 9 months ago (2011-03-19 02:38:35 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698