Issue 6712040: Removed static variable for histograms to avoid race with...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6712040: Removed static variable for histograms to avoid race with... (Closed)

Created:
9 years, 9 months ago by ramant (doing other things)

Modified:
9 years, 7 months ago

Reviewers:
rvargas (doing something else), jar (doing other things)

CC:
chromium-reviews, darin-cc_chromium.org, cbentzel+watch_chromium.org, jam

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Removed static variable for histograms to avoid race with histogram initialization across threads. BUG=76092 TEST=histogram unit tests. Sync tests R=jar Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78809

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -17 lines)			Patch
M	chrome/browser/net/url_info.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/renderer_host/buffered_resource_handler.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	net/base/mime_sniffer.cc	View		8 chunks	+8 lines, -8 lines	0 comments	Download
M	net/disk_cache/histogram_macros.h	View	1 2	4 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

ramant (doing other things)

Hi Jim and Ricardo, Removed the static from histogram's FactoryGet call (or the macros that ...

9 years, 9 months ago (2011-03-18 20:53:31 UTC) #1

rvargas (doing something else)

LGTM to the change... but I would prefer to know if this is really an ...

9 years, 9 months ago (2011-03-18 21:01:39 UTC) #2

LGTM