Log an INFO message whenever we receive an auth challenge....

Log the "Proxy-Support: Session-Based-Authentication"
response header.

Log an INFO message whenever we receive an auth challenge.

R=eroman
BUG=8771
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14108

[eroman, 2009-04-15 22:10:46]

LGTM

http://codereview.chromium.org/67117/diff/1/2
File net/http/http_network_transaction.cc (right):

http://codereview.chromium.org/67117/diff/1/2#newcode1469
Line 1469: while (response_.headers->EnumerateHeader(&iter,
"Proxy-Authenticate",
minor nit: in some of the EnumerateHeader() calls the lowercase header name is
used, and in others the mixed case. I recommend using one style consistently
everywhere.

http://codereview.chromium.org/67117/diff/1/2#newcode1505
Line 1505: << AuthOrigin(target).spec() << " requested auth"
nit: |.spec()| seems unecessary. I would recommend keeping it simple and just
logging the full GURL.

http://codereview.chromium.org/67117/diff/1/2#newcode1526
Line 1526: // Log an error message to help debug http://crbug.com/8771.
I wander if we still need this comment, as it makes it sound temporary.

http://codereview.chromium.org/67117/diff/1/2#newcode1528
Line 1528: << " " << AuthOrigin(target).spec()
ditto to above.

http://codereview.chromium.org/67117/diff/1/3
File net/http/http_network_transaction.h (right):

http://codereview.chromium.org/67117/diff/1/3#newcode203
Line 203: static std::string AuthTargetString(HttpAuth::Target target);
nit: a more general place to put this would be:
std::string HttpAuth::TargetToString(Target target)

[wtc, 2009-04-21 01:42:42]

I made all the changes you suggested except for moving the
AuthTargetString method to HttpAuth::TargetToString, because
I'm not sure if that method is generally useful.

Sorry that I updated the tree, so Patch Set 2 picked up some
unrelated changes.

[eroman, 2009-04-21 02:12:49]

LGTM