Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 6711068: Use v8::internal threading support in samples/shell.cc. (Closed)

Created:
9 years, 9 months ago by Vitaly Repeshko
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Use v8::internal threading support in samples/shell.cc. We need this for isolates testing. To make it work I had to extend the internal Thread constructor with an option to set the stack size (see the comment in shell.cc). BUG=1264 Committed: http://code.google.com/p/v8/source/detail?r=7289

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -122 lines) Patch
M samples/shell.cc View 5 chunks +35 lines, -53 lines 0 comments Download
M src/platform.h View 2 chunks +9 lines, -1 line 0 comments Download
M src/platform-cygwin.cc View 1 chunk +9 lines, -3 lines 0 comments Download
M src/platform-freebsd.cc View 2 chunks +15 lines, -5 lines 0 comments Download
M src/platform-linux.cc View 3 chunks +17 lines, -6 lines 0 comments Download
M src/platform-macos.cc View 4 chunks +18 lines, -7 lines 0 comments Download
M src/platform-nullos.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M src/platform-openbsd.cc View 2 chunks +14 lines, -5 lines 0 comments Download
M src/platform-solaris.cc View 2 chunks +13 lines, -4 lines 0 comments Download
M src/platform-win32.cc View 3 chunks +10 lines, -6 lines 0 comments Download
M test/cctest/cctest.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M test/cctest/test-circular-queue.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-debug.cc View 7 chunks +16 lines, -10 lines 0 comments Download
M test/cctest/test-sockets.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M test/cctest/test-thread-termination.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M test/cctest/test-threads.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Vitaly Repeshko
9 years, 9 months ago (2011-03-21 14:38:59 UTC) #1
Mads Ager (chromium)
9 years, 9 months ago (2011-03-21 14:48:47 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698