Test262

Test262

V8 harness binding for test262.

BUG=
TEST=test262

[Martin Maly, 2011-03-20 04:10:30]

I did little experiment with test262 to see how hard it would be to run it ...
It wasn't too difficult to enable ietestcenter and sputnik_converted portions of
the test since they are close to es5conform harness. There is also sputnik that
hasn't been converted but chances are it is exactly the same test as we already
have to it wouldn't be difficult to hook it to the harness as well.

Apparently es5conform is not getting whole a lot of attention in terms of fixing
test issues so test262 seems like the right way forward.

Please let me know if change like this seems like a good idea.

As for the test expectations, I merely captured existing failures and only went
through handful of them manually to confirm. Which is why most are marked "Bug?"
as they haven't been investigated.

Thank you!
Martin

[Mads Ager (chromium), 2011-03-21 10:18:30]

If es5conform is not evolving at all and test262 is, I agree that we should
switch to use that instead. Since we have sputnik tests running already and they
are currently being updated in the sputnik repository, I think we should start
by only running the es5conform/ietestcenter portion of this. Once the test
support is in the repository for that, we should transfer the buildbots to use
that and remove support for es5conform.

Does that make sense to you?

http://codereview.chromium.org/6711063/diff/1/test/test262/harness-adapt.js
File test/test262/harness-adapt.js (right):

http://codereview.chromium.org/6711063/diff/1/test/test262/harness-adapt.js#n...
test/test262/harness-adapt.js:68: (test.precondition !== undefined) ?
test.precondition.toString() : '',
Let's get rid of the long line. :)

http://codereview.chromium.org/6711063/diff/1/test/test262/jquery.js
File test/test262/jquery.js (right):

http://codereview.chromium.org/6711063/diff/1/test/test262/jquery.js#newcode28
test/test262/jquery.js:28: function $() {}
This seems annoying to have to do. If we cannot get rid of jquery dependency, we
should rename the file to jquery-mock.js or something like that.

[Rico, 2011-03-21 10:23:53]

LGTM

http://codereview.chromium.org/6711063/diff/1/test/test262/testcfg.py
File test/test262/testcfg.py (right):

http://codereview.chromium.org/6711063/diff/1/test/test262/testcfg.py#newcode81
test/test262/testcfg.py:81: harness += [join(self.root, 'data', 'test',
'harness', f) for f in TEST_262_HARNESS]
Long line

http://codereview.chromium.org/6711063/diff/1/test/test262/testcfg.py#newcode101
test/test262/testcfg.py:101: harness += [join(self.root, 'data', 'test',
'harness', f) for f in TEST_262_HARNESS]
Long line

[Martin Maly, 2011-03-28 20:04:21]

Oops, I never pressed the 'm' button. Change already landed with all changes
suggested.

Thanks!
Martin

http://codereview.chromium.org/6711063/diff/1/test/test262/harness-adapt.js
File test/test262/harness-adapt.js (right):

http://codereview.chromium.org/6711063/diff/1/test/test262/harness-adapt.js#n...
test/test262/harness-adapt.js:68: (test.precondition !== undefined) ?
test.precondition.toString() : '',
On 2011/03/21 10:18:30, Mads Ager wrote:
> Let's get rid of the long line. :)

Done.

http://codereview.chromium.org/6711063/diff/1/test/test262/jquery.js
File test/test262/jquery.js (right):

http://codereview.chromium.org/6711063/diff/1/test/test262/jquery.js#newcode28
test/test262/jquery.js:28: function $() {}
On 2011/03/21 10:18:30, Mads Ager wrote:
> This seems annoying to have to do. If we cannot get rid of jquery dependency,
we
> should rename the file to jquery-mock.js or something like that.

Turns out the file wasn't needed. I needed it in the earlier version of the
patch but no longer. Deleted.

http://codereview.chromium.org/6711063/diff/1/test/test262/testcfg.py
File test/test262/testcfg.py (right):

http://codereview.chromium.org/6711063/diff/1/test/test262/testcfg.py#newcode81
test/test262/testcfg.py:81: harness += [join(self.root, 'data', 'test',
'harness', f) for f in TEST_262_HARNESS]
On 2011/03/21 10:23:53, Rico wrote:
> Long line

Done.

http://codereview.chromium.org/6711063/diff/1/test/test262/testcfg.py#newcode101
test/test262/testcfg.py:101: harness += [join(self.root, 'data', 'test',
'harness', f) for f in TEST_262_HARNESS]
On 2011/03/21 10:23:53, Rico wrote:
> Long line

Done.