Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 6711054: Check PrefixSet results for sorting and duplication. (Closed)

Created:
9 years, 9 months ago by Scott Hess - ex-Googler
Modified:
9 years, 6 months ago
Reviewers:
lzheng
CC:
chromium-reviews
Visibility:
Public.

Description

Check PrefixSet results for sorting and duplication. Check whether PrefixSet::GetPrefixes() returns results that are unsorted or contain duplicates, and indicate how many items are unique to the restored vector (or aren't in the restored vector). BUG=71832 TEST=histograms Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78807

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -0 lines) Patch
M chrome/browser/safe_browsing/safe_browsing_database.cc View 2 chunks +52 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Scott Hess - ex-Googler
Scratched together a few minutes to rebase the other changes in. These were the boundary ...
9 years, 9 months ago (2011-03-18 23:38:46 UTC) #1
lzheng
9 years, 9 months ago (2011-03-19 00:43:06 UTC) #2
LGTM.

I started to wonder if there is a bug in STL. Hope we could get more info after
this change.

Powered by Google App Engine
This is Rietveld 408576698