Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1053)

Unified Diff: webkit/plugins/ppapi/ppb_url_loader_impl.cc

Issue 6711047: Fix up some types in the API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Mo' fixes Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/plugins/ppapi/ppb_url_loader_impl.cc
diff --git a/webkit/plugins/ppapi/ppb_url_loader_impl.cc b/webkit/plugins/ppapi/ppb_url_loader_impl.cc
index ccccd254034588ed82943ef8d8d9052aeafd4fe6..bd4c4a6e17a479b5fdfb9ea6bf683689b9b7d34c 100644
--- a/webkit/plugins/ppapi/ppb_url_loader_impl.cc
+++ b/webkit/plugins/ppapi/ppb_url_loader_impl.cc
@@ -122,7 +122,7 @@ PP_Resource GetResponseInfo(PP_Resource loader_id) {
}
int32_t ReadResponseBody(PP_Resource loader_id,
- char* buffer,
+ void* buffer,
int32_t bytes_to_read,
PP_CompletionCallback callback) {
scoped_refptr<PPB_URLLoader_Impl> loader(
@@ -311,7 +311,7 @@ bool PPB_URLLoader_Impl::GetDownloadProgress(
return true;
}
-int32_t PPB_URLLoader_Impl::ReadResponseBody(char* buffer,
+int32_t PPB_URLLoader_Impl::ReadResponseBody(void* buffer,
int32_t bytes_to_read,
PP_CompletionCallback callback) {
int32_t rv = ValidateCallback(callback);
@@ -322,7 +322,7 @@ int32_t PPB_URLLoader_Impl::ReadResponseBody(char* buffer,
if (bytes_to_read <= 0 || !buffer)
return PP_ERROR_BADARGUMENT;
- user_buffer_ = buffer;
+ user_buffer_ = reinterpret_cast<char*>(buffer);
piman 2011/03/24 03:41:36 static_cast
neb 2011/03/25 21:27:10 Done.
user_buffer_size_ = bytes_to_read;
if (!buffer_.empty())

Powered by Google App Engine
This is Rietveld 408576698