Add an opt-out header for HTTP throttling. Never throttle for localhost.

net/url_request/url_request_http_job.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_request_http_job.h"
 
 #include "base/base_switches.h"
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/file_util.h"
@@ skipping 141 matching lines @@
 
   response_info_ = transaction_->GetResponseInfo();
 
   // Save boolean, as we'll need this info at destruction time, and filters may
   // also need this info.
   is_cached_content_ = response_info_->was_cached;
 
   if (!is_cached_content_) {
     URLRequestThrottlerHeaderAdapter response_adapter(
         response_info_->headers);
-    throttling_entry_->UpdateWithResponse(&response_adapter);
+    throttling_entry_->UpdateWithResponse(request_info_.url.host(),

[yzshen1, 2011/03/18 22:49:51]

A throttling entry is used for a specific URL (and therefore, a specific host).
I think we could avoid passing in the host for each UpdateWithResponse call.
Instead, we can do it when the throttling entry is initialized.
What do you think?

[Jói, 2011/03/23 23:38:24]

Storing the host would increase the required storage, since it is not what we
use as a key for url_entries_.  On the other hand, just creating a GURL object
parses the spec of the URL, and this is already done when the HttpRequestInfo
structure is initialized, so passing the host as a parameter should be very
cheap.

[yzshen1, 2011/03/24 20:06:37]

Okay.

On 2011/03/23 23:38:24, Jói wrote:

+                                          &response_adapter);
   }
 
   ProcessStrictTransportSecurityHeader();
 
   if (SdchManager::Global() &&
       SdchManager::Global()->IsInSupportedDomain(request_->url())) {
     static const std::string name = "Get-Dictionary";
     std::string url_text;
     void* iter = NULL;
     // TODO(jar): We need to not fetch dictionaries the first time they are
@@ skipping 820 matching lines @@
 void URLRequestHttpJob::ResetTimer() {
   if (!request_creation_time_.is_null()) {
     NOTREACHED()
         << "The timer was reset before it was recorded.";
     return;
   }
   request_creation_time_ = base::Time::Now();
 }
 
 }  // namespace net