Issue 6711044: Remove std::set from PrefixSet checking code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6711044: Remove std::set from PrefixSet checking code. (Closed)

Created:
9 years, 9 months ago by Scott Hess - ex-Googler

Modified:
9 years, 6 months ago

Reviewers:
lzheng

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Remove std::set from PrefixSet checking code. Some implementations of std::set<> make an allocation per element, with the allocations stitched into a list. This allows iterators to remain valid while other elements in the set are added or removed. Unfortunately, for small elements like SBPrefix in large sets like safe-browsing, this temporarily uses an unexpectedly large amount of memory. [Apologies if I got that wrong!] This refactors things to allow the std::vector<> version to be used. BUG=71832 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78764

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -26 lines)			Patch
	M	chrome/browser/safe_browsing/safe_browsing_database.cc	View		4 chunks	+30 lines, -26 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages