Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 6711037: [gcc] Make command line for static linking similar to what native gcc does (Closed)

Created:
9 years, 9 months ago by eaeltsin
Modified:
9 years, 7 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/git/nacl-gcc@master
Visibility:
Public.

Description

[gcc] Make command line for static linking similar to what native gcc does The problem is that libgcc_eh depends on libc and libc depends on libgcc_eh. For x86_64, everything works as is as all libc dependencies are inlined in libgcc_eh. For x86, there is memcpy call that is not inlined, and our current link specs do not work. Anyway, counting on all libc stuff being inlined is bad. Native gcc does not do that, and uses --start-group/--end-group to resolve these dependencies. This change makes our link specs similar to what native gcc has. BUG=http://code.google.com/p/nativeclient/issues/detail?id=1298 TEST=no more additional -lc for static linking by x86 glibc toolchain Committed: http://git.chromium.org/gitweb/?p=nacl-gcc.git;a=commit;h=0cf0078

Patch Set 1 #

Patch Set 2 : ready for code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M gcc/config/i386/nacl.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
eaeltsin
9 years, 9 months ago (2011-03-18 15:07:02 UTC) #1
pasko-google - do not use
9 years, 9 months ago (2011-03-18 15:51:08 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698