Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 6711035: Fix for talloc, in order to improve mesa shader compiler performance on windows from abysmal to m... (Closed)

Created:
9 years, 9 months ago by Stephen White
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix for talloc, in order to improve mesa shader compiler performance on windows from abysmal to merely poor. The vsnprintf() implementation in MSVC's libc does not conform to C99, and returns -1 if the given buffer is too small to hold the given format. Passing it NULL and a size of zero returns the number of chars required. BUG=NONE TEST=all GPU layout tests R=kbr Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78710

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -11 lines) Patch
M third_party/talloc/README.chromium View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/talloc/chromium.patch View 1 4 chunks +38 lines, -6 lines 0 comments Download
M third_party/talloc/talloc.c View 1 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Stephen White
This works on all platforms, but I can wrap it in an compiler-specific #ifdef if ...
9 years, 9 months ago (2011-03-18 14:27:02 UTC) #1
Ken Russell (switch to Gerrit)
Thanks for tracking that down. LGTM, but could you also update the README.chromium and chromium.patch? ...
9 years, 9 months ago (2011-03-18 16:54:10 UTC) #2
Stephen White
On 2011/03/18 16:54:10, kbr wrote: > Thanks for tracking that down. > > LGTM, but ...
9 years, 9 months ago (2011-03-18 17:10:12 UTC) #3
Ken Russell (switch to Gerrit)
9 years, 9 months ago (2011-03-18 17:14:49 UTC) #4
LGTM; thanks a lot.

Powered by Google App Engine
This is Rietveld 408576698